WIP: check for confirmation of Eth txs when showing balances

Author: webwarrior-ws

src/GWallet.Backend/Account.fs

@@ -248,7 +248,11 @@ module Account =
             txId
             amountTransferredPlusFeeIfCurrencyFeeMatches
             fee.FeeValue
-    
+        match fee with
+        | :? Ether.TransactionMetadata as etherTxMetadata ->
+            Caching.Instance.StoreUnconfirmedTransaction fee.Currency txId etherTxMetadata.Fee.GasLimit
+        | _ -> ()
+
     // FIXME: broadcasting shouldn't just get N consistent replies from FaultTolerantClient,
     // but send it to as many as possible, otherwise it could happen that some server doesn't
     // broadcast it even if you sent it

src/GWallet.Backend/Caching.fs

@@ -14,6 +14,7 @@ type CachedNetworkData =
         UsdPrice: Map<Currency,CachedValue<decimal>>;
         Balances: Map<Currency,Map<PublicAddress,CachedValue<decimal>>>;
         OutgoingTransactions: Map<Currency,Map<PublicAddress,Map<string,CachedValue<decimal>>>>;
+        UnconfirmedTransactions: Map<Currency,list<string * int64>>
     }
     member self.GetLeastOldDate() =
         let allDates =
@@ -35,6 +36,7 @@ type CachedNetworkData =
             UsdPrice = Map.empty
             Balances = Map.empty
             OutgoingTransactions = Map.empty
+            UnconfirmedTransactions = Map.empty
         }
 
     static member FromDietCache (dietCache: DietCache): CachedNetworkData =
@@ -52,7 +54,8 @@ type CachedNetworkData =
                             yield (Currency.Parse currencyStr),Map.empty.Add(address,(balance,now))
             } |> Map.ofSeq
         { UsdPrice = fiatPrices; Balances = balances
-          OutgoingTransactions = Map.empty; }
+          OutgoingTransactions = Map.empty;
+          UnconfirmedTransactions = Map.empty }
 
     member self.ToDietCache(readOnlyAccounts: seq<ReadOnlyAccount>) =
         let rec extractAddressesFromAccounts (acc: Map<PublicAddress,List<DietCurrency>>) (accounts: List<IAccount>)
@@ -647,4 +650,34 @@ module Caching =
         member __.FirstRun
             with get() = firstRun
 
+        member self.StoreUnconfirmedTransaction (currency: Currency) (txHash: string) (gasLimit: int64) =
+            lock cacheFiles.CachedNetworkData (fun _ ->
+                let newTransactions =
+                    match sessionCachedNetworkData.UnconfirmedTransactions |> Map.tryFind currency with
+                    | Some transactionsForCurrency -> (txHash, gasLimit) :: transactionsForCurrency
+                    | None -> List.singleton (txHash, gasLimit)
+                let newCachedData = 
+                    { sessionCachedNetworkData with
+                        UnconfirmedTransactions = 
+                            sessionCachedNetworkData.UnconfirmedTransactions
+                            |> Map.add currency newTransactions }
+                SaveNetworkDataToDisk newCachedData
+            )
+
+        member self.RemoveUnconfirmedTransaction (currency: Currency) (txHash: string) =
+            lock cacheFiles.CachedNetworkData (fun _ ->
+                match sessionCachedNetworkData.UnconfirmedTransactions |> Map.tryFind currency with
+                | Some transactionsForCurrency ->
+                    let newTransactionForCurrency = 
+                        transactionsForCurrency 
+                        |> List.filter (fun (hash, _) -> hash <> txHash)
+                    let newCachedData = 
+                        { sessionCachedNetworkData with
+                            UnconfirmedTransactions = 
+                                sessionCachedNetworkData.UnconfirmedTransactions
+                                |> Map.add currency newTransactionForCurrency }
+                    SaveNetworkDataToDisk newCachedData
+                | None -> ()
+            )
+
     let Instance = MainCache (None, TimeSpan.FromDays 1.0)

src/GWallet.Frontend.Console/UserInteraction.fs

@@ -352,6 +352,24 @@ module UserInteraction =
                     // All balances are fetched and their currency names printed, put a dot at the end of "Retrieving balances... " line.
                     Console.Write '.'
 
+                    let unconfirmedStatuses = ResizeArray<string>()
+                    for account in accounts do
+                        if account.Currency.IsEtherBased() then
+                            let cache = Caching.Instance.GetLastCachedData()
+                            match cache.UnconfirmedTransactions |> Map.tryFind account.Currency with
+                            | Some unconfirmedTransactions ->
+                                for txHash, gasSpent in unconfirmedTransactions do
+                                    try
+                                        let! isOutOfGas = Ether.Server.IsOutOfGas account.Currency txHash gasSpent
+                                        if isOutOfGas then
+                                            unconfirmedStatuses.Add(sprintf "Transaction ran out of gas: 0x%s" txHash)
+                                        else
+                                            Caching.Instance.RemoveUnconfirmedTransaction account.Currency txHash
+                                    with
+                                    | :? TimeoutException ->
+                                        unconfirmedStatuses.Add(sprintf "Timed out when checking transaction 0x%s" txHash)
+                            | None -> ()
+
                     let maybeTotalInUsd, totals = displayTotalAndSumFiatBalance currencyTotals
                     return
                         seq {
@@ -362,6 +380,7 @@ module UserInteraction =
                                     seq {
                                         yield! statuses
                                         yield! totals
+                                        yield! unconfirmedStatuses
                                         yield String.Empty // this ends up being simply an Environment.NewLine
                                         yield sprintf "Total estimated value in USD: %s"
                                                       (Formatting.DecimalAmountRounding CurrencyType.Fiat totalInUsd)