Skip to content

_requestWorker code review and refactor #48

@caver456

Description

@caver456

Looks like definite opportunities to streamline the code in _requestWorker, while also making it more robust and testing more cases:

  • separate clauses for GET/POST/DELETE are largely redundant
  • deferredHook handling - currently only in POST
  • re-signing if the old signature would expire in the next n seconds - currently only in POST
  • investigate exiting the iteration if the request will never return 200 - currently only 200 will clear keepTrying

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions