From bc9baee9ec497270b1ac1fdee0d85890448962a0 Mon Sep 17 00:00:00 2001 From: Darun Seethammagari Date: Tue, 12 Nov 2024 13:40:10 -0800 Subject: [PATCH] Only increment S3 request count on successful request --- block-streamer/src/lake_s3_client.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block-streamer/src/lake_s3_client.rs b/block-streamer/src/lake_s3_client.rs index 9e1afff0f..fc92c8f27 100644 --- a/block-streamer/src/lake_s3_client.rs +++ b/block-streamer/src/lake_s3_client.rs @@ -144,12 +144,12 @@ impl LakeS3Client { let prefix = prefix.to_owned(); async move { - metrics::LAKE_S3_GET_REQUEST_COUNT.inc(); - let object = s3_client.get_object(&bucket, &prefix).await?; let bytes = object.body.collect().await?.into_bytes().to_vec(); + metrics::LAKE_S3_GET_REQUEST_COUNT.inc(); + Ok(bytes) } .boxed()