feat(sda-validator-orchestrator): result API validate that validation id is a UUID

KarlG-nbis · KarlG-nbis · commit 0ca56ecef154 · 2025-11-05T09:09:03.000+01:00
diff --git a/sda-validator/orchestrator/api/api.go b/sda-validator/orchestrator/api/api.go
@@ -71,8 +71,9 @@ func (api *validatorAPIImpl) ResultGet(c *gin.Context) {
 }
 
 func (api *validatorAPIImpl) result(c *gin.Context, validationID string, userID *string) {
-	if validationID == "" {
-		c.AbortWithStatus(http.StatusBadRequest)
+
+	if _, err := uuid.Parse(validationID); err != nil {
+		c.JSON(http.StatusBadRequest, gin.H{"error": fmt.Sprintf("Invalid validation id: %s", validationID)})
 
 		return
 	}

Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,9 @@ func (api validatorAPIImpl) ResultGet(c gin.Context) {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`func (api validatorAPIImpl) result(c gin.Context, validationID string, userID *string) {`
`74`		`- if validationID == "" {`
`75`		`- c.AbortWithStatus(http.StatusBadRequest)`
	`74`	`+`
	`75`	`+ if _, err := uuid.Parse(validationID); err != nil {`
	`76`	`+ c.JSON(http.StatusBadRequest, gin.H{"error": fmt.Sprintf("Invalid validation id: %s", validationID)})`
`76`	`77`
`77`	`78`	`return`
`78`	`79`	`}`