TASK: Cleanup Neos.Fusion:GlobalCacheIdentifiers by removing workspaceChain
#5674
+0
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paceChain` in Neos 9 (ESCR) the workspace is no longer a fallback but a full copy of the base workspace content stream from a certain point. Any changes like base workspace change or publish or discard will lead to a full workspace cache flush (which is a new cache tag) There is no shine through from the base workspace and to explicitly request the new contents synchronise is uses (which is a RebaseWorkspaces and flushes the full workspace)
mhsdesign
commented
Nov 19, 2025
| * @param Node|null $node | ||
| * @return array<string,Workspace> | ||
| */ | ||
| public function getWorkspaceChain(?Node $node): array |
Member
Author
There was a problem hiding this comment.
this helper method is removed for the minor release 9.1 i think its okay as a: the method is not documented and thus not as much api as say nodeTypeTag and b: its absolutely useless for caching in Neos 9 thats why we remove it ourselves as well. So if anyone upgrading to 9.1 finds a reference to that in his cache config it can just be removed.
If you disagree ill have that removed for 10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Neos 9 (ESCR) the workspace is no longer a fallback but a full copy of the base workspace content stream from a certain point. Any changes like base workspace change or publish or discard will lead to a full workspace cache flush (which is a new cache tag) There is no shine through from the base workspace and to explicitly request the new contents synchronise is uses (which is a RebaseWorkspaces and flushes the full workspace)
cleanup to #5221 which introduces
Workspacecontent cache tags (\Neos\Neos\Fusion\Cache\CacheTag::forWorkspaceName())Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions