fix: failed upload retry #15862
Draft
fix: failed upload retry #15862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
changed the title
4 tasks
alperozturk96
changed the title
alperozturk96
commented
Oct 28, 2025
|
|
||
| val fileEntity = | ||
| fileDataStorageManager.fileDao.getFileByDecryptedRemotePath(remotePath, user.accountName) | ||
| if (fileEntity != null) { |
Collaborator
Author
There was a problem hiding this comment.
Check existence file on remote
alperozturk96
commented
Oct 28, 2025
| continue | ||
| } | ||
|
|
||
| uploads.add(failedUpload.uploadId) |
Collaborator
Author
There was a problem hiding this comment.
Only add checked failed uploads.
alperozturk96
commented
Oct 28, 2025
| val remotePath = upload.remotePath ?: continue | ||
| val fileExists = | ||
| fileStorageManager.fileDao.getFileByDecryptedRemotePath(remotePath, accountName) != null | ||
| if (fileExists) { |
Collaborator
Author
There was a problem hiding this comment.
Check existence file on remote
Member
For sync conflict the settings must be obeyed. |
tobiasKaminsky
requested changes
Oct 29, 2025
Member
tobiasKaminsky
left a comment
tobiasKaminsky
left a comment
There was a problem hiding this comment.
Please obey settings for sync conflict.
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
fix/failed-upload-retry
branch
from
516fc83 to
e22ee13
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15862.apk |
Collaborator
Author
|
Better to split this PR so that we can proceed faster and easy to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After a failed auto-upload or manual upload, some entities remain marked as failed. As a result, the same uploads are triggered again (due to SYNC_CONFLICT, wrongly chosen failed upload IDs for upload) on every app launch or pull-to-refresh from various screens.
Changes
Checks for the existence of the file at the remote path and removes the corresponding upload entity if the file already exists
Fixes DB update
Chooses failed uploads correctly