Skip to content

Commit 027d1ca

Browse files
committed
fix: Expose already used public interface methods
Signed-off-by: Julius Knorr <[email protected]>
1 parent b469840 commit 027d1ca

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

build/psalm-baseline.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1399,7 +1399,6 @@
13991399
</InvalidArgument>
14001400
<UndefinedInterfaceMethod>
14011401
<code><![CDATA[getTemplates]]></code>
1402-
<code><![CDATA[open]]></code>
14031402
</UndefinedInterfaceMethod>
14041403
</file>
14051404
<file src="apps/files/lib/Helper.php">

lib/public/DirectEditing/IManager.php

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function registerDirectEditor(IEditor $directEditor): void;
3636
public function edit(string $token): Response;
3737

3838
/**
39-
* Create a new token based on the file path and editor details
39+
* Create a file and generate a token based on the file path and editor details
4040
*
4141
* @since 18.0.0
4242
* @param string $path
@@ -49,6 +49,19 @@ public function edit(string $token): Response;
4949
*/
5050
public function create(string $path, string $editorId, string $creatorId, $templateId = null): string;
5151

52+
/**
53+
* Create a token based on an existing file path and editor details
54+
*
55+
* @since 33.0.0
56+
* @param string $filePath
57+
* @param string|null $editorId
58+
* @param int|null $fileId
59+
* @return string
60+
* @throws NotPermittedException
61+
* @throws RuntimeException
62+
*/
63+
public function open(string $filePath, ?string $editorId = null, ?int $fileId = null): string;
64+
5265
/**
5366
* Get the token details for a given token
5467
*

lib/public/DirectEditing/IToken.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,4 +62,10 @@ public function getEditor(): string;
6262
* @return string
6363
*/
6464
public function getUser(): string;
65+
66+
/**
67+
* @since 33.0.0
68+
* @return string
69+
*/
70+
public function getToken(): string;
6571
}

0 commit comments

Comments
 (0)