Skip to content

Commit 04538ba

Browse files
committed
chore: update workflows from templates
Signed-off-by: skjnldsv <[email protected]>
1 parent e941eab commit 04538ba

File tree

2 files changed

+26
-10
lines changed

2 files changed

+26
-10
lines changed

.github/workflows/appstore-build-publish.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
echo "APP_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV
3333
3434
- name: Checkout
35-
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
35+
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
3636
with:
3737
path: ${{ env.APP_NAME }}
3838

@@ -63,7 +63,7 @@ jobs:
6363
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
6464
# Skip if no package.json
6565
if: ${{ steps.versions.outputs.npmVersion }}
66-
run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}"
66+
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
6767

6868
- name: Get php version
6969
id: php-versions
@@ -72,7 +72,7 @@ jobs:
7272
filename: ${{ env.APP_NAME }}/appinfo/info.xml
7373

7474
- name: Set up php ${{ steps.php-versions.outputs.php-min }}
75-
uses: shivammathur/setup-php@c665c7a15b5295c2488ac8a87af9cb806cd72198 # v2
75+
uses: shivammathur/setup-php@2e947f1f6932d141d076ca441d0e1e881775e95b # v2.31.0
7676
with:
7777
php-version: ${{ steps.php-versions.outputs.php-min }}
7878
coverage: none
@@ -129,12 +129,12 @@ jobs:
129129
continue-on-error: true
130130
id: server-checkout
131131
run: |
132-
NCVERSION=${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
132+
NCVERSION='${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}'
133133
wget --quiet https://download.nextcloud.com/server/releases/latest-$NCVERSION.zip
134134
unzip latest-$NCVERSION.zip
135135
136136
- name: Checkout server master fallback
137-
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
137+
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
138138
if: ${{ steps.server-checkout.outcome != 'success' }}
139139
with:
140140
submodules: true
@@ -148,7 +148,7 @@ jobs:
148148
tar -xvf ${{ env.APP_NAME }}.tar.gz
149149
cd ../../../
150150
# Setting up keys
151-
echo "${{ secrets.APP_PRIVATE_KEY }}" > ${{ env.APP_NAME }}.key
151+
echo '${{ secrets.APP_PRIVATE_KEY }}' > ${{ env.APP_NAME }}.key
152152
wget --quiet "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
153153
# Signing
154154
php nextcloud/occ integrity:sign-app --privateKey=../${{ env.APP_NAME }}.key --certificate=../${{ env.APP_NAME }}.crt --path=../${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}

.github/workflows/pr-feedback.yml

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@
33
# https://github.com/nextcloud/.github
44
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
55

6+
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
7+
# SPDX-FileCopyrightText: 2023 Marcel Klehr <[email protected]>
8+
# SPDX-FileCopyrightText: 2023 Joas Schilling <[email protected]>
9+
# SPDX-FileCopyrightText: 2023 Daniel Kesselberg <[email protected]>
10+
# SPDX-FileCopyrightText: 2023 Florian Steffens <[email protected]>
11+
# SPDX-License-Identifier: MIT
12+
613
name: 'Ask for feedback on PRs'
714
on:
815
schedule:
@@ -17,18 +24,27 @@ jobs:
1724
id: scrape
1825
with:
1926
website: 'https://nextcloud.com/team/'
20-
- uses: marcelklehr/pr-feedback-action@601109aa729eb4c8d6d0ece7567b9d4901db4aef
27+
28+
- name: Get blocklist
29+
id: blocklist
30+
run: |
31+
blocklist=$(curl https://raw.githubusercontent.com/nextcloud/.github/master/non-community-usernames.txt | paste -s -d, -)
32+
echo "blocklist=$blocklist" >> "$GITHUB_OUTPUT"
33+
34+
- uses: marcelklehr/pr-feedback-action@1883b38a033fb16f576875e0cf45f98b857655c4
2135
with:
2236
feedback-message: |
2337
Hello there,
24-
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
38+
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
2539
2640
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
2741
2842
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
2943
3044
Thank you for contributing to Nextcloud and we hope to hear from you soon!
45+
46+
(If you believe you should not receive this message, you can add yourself to the [blocklist](https://github.com/nextcloud/.github/blob/master/non-community-usernames.txt).)
3147
days-before-feedback: 14
32-
start-date: "2023-07-10"
33-
exempt-authors: "${{ steps.scrape.outputs.users }},nextcloud-command,nextcloud-android-bot,skjnldsv,datenangebot"
48+
start-date: '2024-04-30'
49+
exempt-authors: '${{ steps.blocklist.outputs.blocklist }},${{ steps.scrape.outputs.users }},nextcloud-command,nextcloud-android-bot'
3450
exempt-bots: true

0 commit comments

Comments
 (0)