Fix String.format error when plugin URL contains percent chars (#6651)

Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Claude Opus 4.5 <[email protected]>
Co-authored-by: Ben Sherman <[email protected]>

Author: 3 people

modules/nf-commons/src/main/nextflow/plugin/HttpPluginRepository.groovy

@@ -137,7 +137,7 @@ class HttpPluginRepository implements PrefetchUpdateRepository {
             throw e
         }
         catch (Exception e) {
-            throw new PluginRuntimeException(e, "Unable to connect to ${uri} - cause: ${e.message}")
+            throw new PluginRuntimeException(e, "Unable to connect to %s - cause: %s", uri, e.message)
         }
     }
 

modules/nf-commons/src/test/nextflow/plugin/HttpPluginRepositoryTest.groovy

@@ -104,6 +104,26 @@ class HttpPluginRepositoryTest extends Specification {
 
     // ------------------------------------------------------------------------
 
+    def 'handle prefetch error with percent chars in error message'() {
+        given:
+        // Test that URLs containing '%' characters (like URL-encoded values) are handled
+        // correctly when an exception occurs. The '%' must be escaped to '%%' to avoid
+        // String.format interpretation in PluginRuntimeException.
+        def repoWithEncodedUrl = new HttpPluginRepository("test-repo", new URI("http://localhost:${wiremock.port()}/path%20with%20spaces/"))
+        wiremock.stop()
+
+        when:
+        repoWithEncodedUrl.prefetch([new PluginRef("nf-fake")])
+
+        then:
+        def err = thrown PluginRuntimeException
+        // Verify the error message is properly formatted and contains the URL with encoded spaces
+        err.message.contains("Unable to connect to")
+        err.message.contains("path%20with%20spaces")
+    }
+
+    // ------------------------------------------------------------------------
+
     def 'handle prefetch error when metadata service returns an error response'() {
         given:
         wiremock.stubFor(get(urlEqualTo("/v1/plugins/dependencies?plugins=nf-fake&nextflowVersion=${BuildInfo.version}"))