Skip to content

Commit 0d197d5

Browse files
author
gokulprasanth-ni
committed
add comments to the newly added rules in the project's eslint.config.js
Signed-off-by: gokulprasanth-ni <[email protected]>
1 parent d6a557c commit 0d197d5

File tree

7 files changed

+31
-24
lines changed

7 files changed

+31
-24
lines changed
Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
import { javascriptConfig } from '@ni/eslint-config-javascript';
22

33
export default [
4-
...javascriptConfig,
5-
{
6-
ignores: ['eslint.config.js'],
7-
},
8-
{
9-
files: ['**/*.js'],
10-
rules: {
11-
'import/no-extraneous-dependencies': 'off',
12-
},
13-
},
4+
...javascriptConfig,
5+
{
6+
ignores: ['eslint.config.js'],
7+
},
8+
{
9+
files: ['**/*.js'],
10+
rules: {
11+
// Disable this rule because some packages used in the project are not listed in devDependencies or dependencies.
12+
'import/no-extraneous-dependencies': 'off',
13+
},
14+
},
1415
];
Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
import { javascriptConfig } from '@ni/eslint-config-javascript';
22

33
export default [
4-
...javascriptConfig,
5-
{
6-
ignores: ['eslint.config.js'],
7-
},
8-
{
9-
files: ['**/*.js'],
10-
rules: {
11-
'import/extensions': 'off',
12-
'import/no-extraneous-dependencies': 'off',
13-
},
14-
},
4+
...javascriptConfig,
5+
{
6+
ignores: ['eslint.config.js'],
7+
},
8+
{
9+
files: ['**/*.js'],
10+
rules: {
11+
// Disable these rules because some packages used in the project are not listed in devDependencies or dependencies, and ES6 modules require explicit file extensions by default.
12+
'import/extensions': 'off',
13+
'import/no-extraneous-dependencies': 'off',
14+
},
15+
},
1516
];

packages/eslint-config-playwright/eslint.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export default [
77
},
88
{
99
rules: {
10+
// Disable this rule because some packages used in the project are not listed in devDependencies or dependencies.
1011
'import/no-extraneous-dependencies': 'off',
1112
},
1213
},

packages/eslint-config-typescript/eslint.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export default [
88
{
99
files: ['**/*.js'],
1010
rules: {
11+
// Disable these rules because some packages used in the project are not listed in devDependencies or dependencies, and ES6 modules require explicit file extensions by default.
1112
'import/extensions': 'off',
1213
'import/no-extraneous-dependencies': 'off',
1314
'import/no-unresolved': 'off',

tests/angular/tsconfig.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
{
22
"compilerOptions": {
3-
"experimentalDecorators": true
3+
"experimentalDecorators": true,
4+
"strictNullChecks": true,
5+
"moduleResolution": "node",
6+
"target": "ES2020"
47
},
58
"include": ["."]
69
}

tests/playwright/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"files": ["./index.ts"],
33
"compilerOptions": {
4-
"strictNullChecks": false,
4+
"strictNullChecks": true,
55
"moduleResolution": "node",
66
"target": "ES2020"
77
}

tests/typescript/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"files": ["./index.ts"],
33
"compilerOptions": {
4-
"strictNullChecks": false,
4+
"strictNullChecks": true,
55
"target": "ES2020"
66
}
77
}

0 commit comments

Comments
 (0)