Skip to content

Commit df5b22c

Browse files
author
gokulprasanth-ni
committed
address lvl 1 PR comments
Signed-off-by: gokulprasanth-ni <[email protected]>
1 parent ca9199c commit df5b22c

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@
5151
"beachball": "^2.41.0"
5252
},
5353
"peerDependencies": {
54-
"typescript": "~5.0.0"
54+
"typescript": "~5.4.5"
5555
}
5656
}

packages/eslint-config-javascript/rules/style.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,8 +455,7 @@ export const style = {
455455
],
456456

457457
/*
458-
disallow space between function identifier and application
459-
deprecated in favor of func-call-spacing
458+
enforce spacing between functions and their invocations
460459
https://eslint.style/rules/function-call-spacing
461460
*/
462461
'@stylistic/function-call-spacing': ['error', 'never'],

packages/eslint-config-typescript/index.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default [
3737

3838
/*
3939
[strict-null-checks]
40-
With `stickNullChecks` disabled, non-null assertions are discouraged (this rule is configured as 'error')
40+
With `strictNullChecks` disabled, non-null assertions are discouraged (this rule is configured as 'error')
4141
as non-null assertions do not provide additional type safety and if used inconsistently add to visual noise.
4242
With `strictNullChecks` enabled, the non-null assertion operator (this rule configured as 'off')
4343
is useful for asserting that a value will no longer be null and usage of operator should be allowed.
@@ -46,11 +46,6 @@ export default [
4646

4747
'valid-typeof': 'off',
4848

49-
/*
50-
Overrides to TypeScript stylistic rules:
51-
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/stylistic.ts
52-
*/
53-
5449
/*
5550
Overrides to Typescript rules outside of the recommended configuration:
5651
*/
@@ -92,6 +87,11 @@ export default [
9287
{ accessibility: 'explicit', overrides: { constructors: 'off' } }
9388
],
9489

90+
/*
91+
Overrides to TypeScript stylistic rules:
92+
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/flat/stylistic.ts
93+
*/
94+
9595
/*
9696
All interface members should be terminated with a semicolon including single line
9797
definitions, consistent with classes. Object literal types should use commas
@@ -118,6 +118,8 @@ export default [
118118
}
119119
}],
120120

121+
'@stylistic/type-annotation-spacing': 'error',
122+
121123
/*
122124
Group members by fields and methods and then order them by accessibility starting
123125
with statics. Order members within these groups in a logical organization where
@@ -219,8 +221,6 @@ export default [
219221
*/
220222
'@typescript-eslint/sort-type-union-intersection-members': 'off',
221223

222-
'@stylistic/type-annotation-spacing': 'error',
223-
224224
/*
225225
This rule is better enforced with the TypeScript `noImplicitAny` and
226226
`strictPropertyInitialization` compiler options.

0 commit comments

Comments
 (0)