Skip to content

Update package.json #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JagjitKaur wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update package.json #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "pako",
"description": "zlib port to javascript - fast, modularized, with browser support",
"version": "2.1.0",
"sideeffects": false,
Copy link

@Greenheart Greenheart Mar 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs you linked, the property should be sideEffects- note the casing difference.

Suggested change:

Suggested change
"sideeffects": false,
"sideEffects": false,

Copy link

@JagjitK JagjitK Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done the change. @Greenheart Could you please approve?
JagjitKaur#1

Copy link

@Greenheart Greenheart Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you push the change to the same branch as this PR is based on (JagjitKaur:Pako/tree-shaking)?

I'm not a maintainer of this project, so I can't decide whether to merge or not.

However, this is consistent with the Webpack docs - hope it helps your project :)

"keywords": [
"zlib",
"deflate",
Expand Down