Skip to content

update evaluation set size on sortedDataSelection #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

update evaluation set size on sortedDataSelection #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/selection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,10 @@ class SelectionTile {
addSort(key: string, getter: (row: StructRowProxy) => number) {
const { bitmask } = this;
const indices = Bitmask.from_arrow(bitmask).which();
const pairs: [number, number][] = new Array(indices.length);
const pairs: [number, number][] = [];
for (let i = 0; i < indices.length; i++) {
const v = getter(this.tile.record_batch.get(indices[i]));
pairs[i] = [v, indices[i]];
pairs.push([v, indices[i]]);
}
pairs.sort((a, b) => a[0] - b[0]);
const values = new Float64Array(indices.length);
Expand Down Expand Up @@ -1046,7 +1046,7 @@ export class SortedDataSelection extends DataSelection {
{
name: Math.random().toFixed(10).slice(2),
tileFunction: async (tile: Tile): Promise<Vector<Bool>> =>
tile.get_column(sel.name),
(await tile.get_column(sel.name)) as Vector<Bool>,
},
sortOperation,
neededFields,
Expand All @@ -1064,6 +1064,10 @@ export class SortedDataSelection extends DataSelection {
);
newer.tiles = await Promise.all(withSort);
newer.selectionSize = newer.tiles.reduce((sum, t) => sum + t.matchCount, 0);
newer.evaluationSetSize = newer.tiles.reduce(
(sum, t) => sum + t.tile.manifest.nPoints,
0,
);
return newer;
}
// In addition to the regular things, we also need to add sort fields.
Expand Down