Skip to content

Conversation

@cgivre
Copy link

@cgivre cgivre commented Nov 11, 2024

Describe your changes

This PR adds two configuration options: proxies and verify_ssl to the constructor and any methods which make GET requests using the requests.get() method. I added default values so that the existing behavior should remain the same.

Issue ticket number and link

Issue 3068
#3068

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Notes

This PR allows users to use the SDK in corporate environments.

@cgivre cgivre force-pushed the add-requests-options branch from 5b2481b to a00b012 Compare November 11, 2024 22:47
@cgivre cgivre changed the title Add Proxy and SSL Config Options Add Proxy and SSL Config Options to Python SDK Nov 12, 2024
@cgivre
Copy link
Author

cgivre commented Nov 26, 2024

@cebtenzzre Any chance we could get this reviewed?

cebtenzzre and others added 25 commits February 4, 2025 12:22
…c-ai#3147)

Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Adam Treat <[email protected]>
Co-authored-by: Adam Treat <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Riccardo Giovanetti <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Co-authored-by: Jared Van Bortel <[email protected]>
Signed-off-by: Victor <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Co-authored-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre and others added 30 commits February 4, 2025 12:22
…omic-ai#3412)

Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Co-authored-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Adam Treat <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Co-authored-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
This reverts commit c38c745.

Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Andriy Mulyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants