WIP: Icon buttons for file selection and creation

Saves (horizontal) space, important on phones.

Also allows to create snapshot files that way.

TODO:
- Document and test createDialogLoader logic
- Proper button on desktop
- Rename saveDialogSupported to saveDialogCanOverwrite?

Author: Vogtinator

qml/ConfigPageKits.qml

@@ -78,32 +78,23 @@ ColumnLayout {
                 elide: Text.ElideMiddle
             }
 
-            ColumnLayout {
+            FileSelect {
+                id: flashEdit
                 Layout.fillWidth: true
-
-                FileSelect {
-                    id: flashEdit
-                    Layout.fillWidth: true
-                    filePath: kitList.currentItem.myData.flash
-                    onFilePathChanged: {
-                        if(filePath !== kitList.currentItem.myData.flash)
-                            kitModel.setDataRow(kitList.currentIndex, filePath, KitModel.FlashRole);
-                        filePath = Qt.binding(function() { return kitList.currentItem.myData.flash; });
-                    }
-                }
-
-                FlashDialog {
-                    id: flashDialog
-                    onFlashCreated: {
+                filePath: kitList.currentItem.myData.flash
+                onFilePathChanged: {
+                    if(filePath !== kitList.currentItem.myData.flash)
                         kitModel.setDataRow(kitList.currentIndex, filePath, KitModel.FlashRole);
-                    }
+                    filePath = Qt.binding(function() { return kitList.currentItem.myData.flash; });
                 }
+                showCreateButton: true
+                onCreate: flashDialog.visible = true
+            }
 
-                Button {
-                    id: createButton
-                    Layout.alignment: Qt.AlignRight
-                    text: qsTr("New")
-                    onClicked: flashDialog.visible = true
+            FlashDialog {
+                id: flashDialog
+                onFlashCreated: {
+                    kitModel.setDataRow(kitList.currentIndex, filePath, KitModel.FlashRole);
                 }
             }
 

qml/Firebird/UIComponents/FileSelect.qml

@@ -5,9 +5,10 @@ import QtQuick.Layouts 1.0
 import Firebird.Emu 1.0
 
 RowLayout {
-    id: root
     property string filePath: ""
     property bool selectExisting: true
+    property bool showCreateButton: false
+    signal create()
 
     Loader {
         id: dialogLoader
@@ -38,13 +39,41 @@ RowLayout {
         color: (!selectExisting || filePath === "" || Emu.fileExists(filePath)) ? paletteActive.text : "red"
     }
 
-    Button {
-        id: selectButton
-        text: qsTr("Select")
+    // Button for either custom creation functionality (onCreate) or
+    // if the open file dialog doesn't allow creation, to open a file creation dialog.
+    ToolButton {
+        text: qsTr("New")
+        visible: showCreateButton || (!selectExisting && !Emu.saveDialogSupported())
+        iconSource: "qrc:/icons/resources/icons/document-new.png"
+        onClicked: {
+            if(showCreateButton)
+                parent.create()
+            else {
+                createDialogLoader.active = true;
+                createDialogLoader.item.visible = true;
+            }
+        }
 
+        Loader {
+            id: createDialogLoader
+            active: false
+            sourceComponent: FileDialog {
+                folder: filePath ? Emu.dir(filePath) : Global.lastFileDialogDir
+                selectExisting: false
+                onAccepted: {
+                    filePath = Emu.toLocalFile(fileUrl);
+                    Global.lastFileDialogDir = Emu.dir(filePath);
+                }
+            }
+        }
+    }
+
+    ToolButton {
+        text: qsTr("Select")
+        iconSource: "qrc:/icons/resources/icons/document-edit.png"
         onClicked: {
-            dialogLoader.active = true
-            dialogLoader.item.visible = true
+            dialogLoader.active = true;
+            dialogLoader.item.visible = true;
         }
     }
 }

qml/FlashDialog.qml

@@ -23,7 +23,7 @@ Dialog {
     GridLayout {
         id: layout
         width: parent.width
-        columns: width > modelCombo.implicitWidth * 2 ? 2 : 1
+        columns: 2
 
         FBLabel {
             Layout.minimumHeight: implicitHeight

resources.qrc

@@ -22,6 +22,8 @@
         <file>resources/icons/drive-removable-media-usb.png</file>
         <file>resources/icons/smartphone.png</file>
         <file>resources/icons/video-display.png</file>
+        <file>resources/icons/document-edit.png</file>
+        <file>resources/icons/document-new.png</file>
     </qresource>
     <qresource prefix="/qml">
         <file>qml/Keypad.qml</file>