feat: use system OpenSSL by default

[kiranshila]

Feature-gates vendoring OpenSSL with vendored-openssl.

Fixes #443

[gemini-code-assist]

Summary of Changes

Hello @kiranshila, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the project's Cargo.toml to change how the openssl dependency is handled. The primary goal is to shift from vendoring OpenSSL by default to utilizing the system's installed OpenSSL. To maintain flexibility for users who might still require vendored OpenSSL, a new feature gate, vendored-openssl, has been added, allowing them to explicitly enable this behavior. This change addresses issue #443.

Highlights

• Default OpenSSL Behavior: The openssl dependency in Cargo.toml no longer defaults to vendoring its own OpenSSL. It will now rely on the system's OpenSSL installation by default, reducing the project's footprint and potentially simplifying builds in environments with existing OpenSSL.
• New Feature Gate for Vendoring: A new feature, vendored-openssl, has been introduced. This feature allows users to explicitly opt-in to vendoring OpenSSL if their specific build environment or requirements necessitate it, providing flexibility without making it the default.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies Cargo.toml to change how the openssl dependency is handled. It moves from always vendoring OpenSSL to using the system's OpenSSL library by default, and introduces a vendored-openssl feature to opt-in to vendoring. This is a good practice that improves flexibility for users of this crate. The implementation is correct. I have one suggestion regarding the implications of this change for versioning and documentation.

[gemini-code-assist]

This change to use the system's OpenSSL by default is a great improvement. However, it is a breaking change for users who relied on the vendored version and do not have OpenSSL development libraries installed. According to semantic versioning, this change should be accompanied by a minor version bump (e.g., to 4.3.0). It would also be beneficial to document this new build requirement in the project's README.md to inform users about the need to have OpenSSL installed on their system when using features that depend on it.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.02%. Comparing base (a96f2e1) to head (865635c).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files          23       23           
  Lines        3570     3570           
=======================================
  Hits         2964     2964           
  Misses        606      606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ChristopherRabotin]

It looks like the Python build requires the vendor feature.