Skip to content

upgrade: bump mina #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

upgrade: bump mina #2447

merged 1 commit into from
Oct 15, 2025

Conversation

@bleepbloopsify
Copy link
Contributor

@bleepbloopsify bleepbloopsify commented Sep 24, 2025 •
edited
Loading

upgrade: bumping mina (after a long time) to compatible (8f958aac99f53f27ce34e62861775d7117821a2c)

downgrades dune to 3.1 to be compatible
upgrades node to 22.0 for wasm support (across our CI)
nix rust toolchain upgrade to 2024-09-05
fixes API incompatibilities
adds .gitattributes to some improper files
fixes our dune files to have more standard flag usage (for better
inheritance)
adds a dependency debug line to a dune invocation in order to give
better tracing for objects when building (doesn't affect happy path)

Status: expected to work as soon as CI finishes

this is the root of a trunk.
children: #2502

@bleepbloopsify bleepbloopsify requested review from a team as code owners September 24, 2025 18:51
@bleepbloopsify bleepbloopsify force-pushed the leon/bump-mina branch 3 times, most recently from e5a01eb to 8d9022b Compare September 29, 2025 17:41
@bleepbloopsify bleepbloopsify changed the title [DNM] bump mina bump mina Sep 29, 2025
@bleepbloopsify bleepbloopsify force-pushed the leon/bump-mina branch 3 times, most recently from 5dfb688 to 3f6119b Compare September 30, 2025 17:54
@bleepbloopsify bleepbloopsify self-assigned this Oct 1, 2025
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 1, 2025

I don't have a nix setup, so if someone does have one, it would be nice if they could go format that flake.nix (if it isn't formatted)

@bleepbloopsify bleepbloopsify marked this pull request as draft October 1, 2025 21:16
@bleepbloopsify bleepbloopsify marked this pull request as ready for review October 1, 2025 21:16
@bleepbloopsify bleepbloopsify marked this pull request as draft October 2, 2025 15:09
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 3, 2025

uhhh.... I think I did it?

the weirdest thing - bumping nodejs to 22 actually fixed a lot of the wasm problems we were having? how strange

@bleepbloopsify bleepbloopsify changed the title bump mina upgrade: bump mina Oct 3, 2025
@bleepbloopsify bleepbloopsify marked this pull request as ready for review October 3, 2025 18:11
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 6, 2025

Continuing conversation here:
Since this breaks Node 20 support, we need to move this to the next major release

@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 6, 2025 •
edited
Loading

#1885 Looks like last time node was bumped (in breaking fashion) was here, investigating

This also works on node 21.7.3, bisecting further, also works on node 21.0.0

@bleepbloopsify bleepbloopsify force-pushed the leon/bump-mina branch 4 times, most recently from 9674e48 to e675578 Compare October 13, 2025 14:41
@bleepbloopsify bleepbloopsify changed the base branch from main to leon/develop-from-main October 13, 2025 14:42
@bleepbloopsify
Copy link
Contributor Author

bleepbloopsify commented Oct 13, 2025

updated this branch to target develop instead of main, as we don't want to drop node20 quite yet

@bleepbloopsify bleepbloopsify mentioned this pull request Oct 13, 2025
Merged
Base automatically changed from leon/develop-from-main to develop October 14, 2025 15:46
Shigoto-dev19
Shigoto-dev19 approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@Shigoto-dev19 Shigoto-dev19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just left a comment about the change adding ~signature_kind in local-ledger.ml

src/bindings/crypto/.gitattributes
Copy link
Contributor

@Shigoto-dev19 Shigoto-dev19 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

src/bindings/ocaml/lib/local_ledger.ml
let ledger = l##.value in
let application_result =
Transaction_logic.apply_zkapp_command_unchecked
Transaction_logic.apply_zkapp_command_unchecked ~signature_kind
Copy link
Contributor

@Shigoto-dev19 Shigoto-dev19 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems different that what the PR is addressing.
Could you add more details about it in the PR description?

Copy link
Member

@Trivo25 Trivo25 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is due to a change in the mina repo I'd imagine

Copy link
Contributor Author

@bleepbloopsify bleepbloopsify Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, api change

@bleepbloopsify bleepbloopsify merged commit 1a3ca07 into develop Oct 15, 2025
25 checks passed
@bleepbloopsify bleepbloopsify deleted the leon/bump-mina branch October 15, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

@Shigoto-dev19 Shigoto-dev19 Shigoto-dev19 approved these changes

@45930 45930 Awaiting requested review from 45930 45930 is a code owner automatically assigned from o1-labs/exploration-team

Assignees

@bleepbloopsify bleepbloopsify

Labels

no changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bleepbloopsify @Trivo25 @Shigoto-dev19