Skip to content

Conversation

@florianl
Copy link
Contributor

@florianl florianl commented Dec 3, 2025

Description

In #14239 (Profiles)ProfileCount() int was introduced. Provide this function also in consumertests for other tests.

Link to tracking issue

Fixes #

Testing

Documentation

In open-telemetry#14239 (Profiles)ProfileCount() was introduced. Provide this function also in consumertests.

Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl requested a review from a team as a code owner December 3, 2025 09:06
@florianl florianl requested a review from codeboten December 3, 2025 09:06
@florianl
Copy link
Contributor Author

florianl commented Dec 3, 2025

I'm unsure wheter or not this change requires a changelog. For the moment, I marked it as [chore] as it does not touch a component that is ending up in production. Furthermore, consumer/consumertest is also not a listed component in .chloggen/config.yaml.

If you want to see a changelog, I'm happy to apply - please let me know.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #14251 will degrade performances by 37.38%

Comparing florianl:profiles-consumertest (2fc136d) with main (ced8cda)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 1 regression
✅ 72 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
zstdWithConcurrency 18.4 µs 29.3 µs -37.38%

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (ced8cda) to head (2fc136d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14251      +/-   ##
==========================================
- Coverage   92.18%   92.15%   -0.04%     
==========================================
  Files         668      668              
  Lines       41472    41478       +6     
==========================================
- Hits        38232    38223       -9     
- Misses       2209     2219      +10     
- Partials     1031     1036       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Florian Lehner <[email protected]>
@dmathieu
Copy link
Member

dmathieu commented Dec 3, 2025

This changes a public API. So it needs a changelog entry.
I've opened a PR adding a metadata.yaml to the package. #14252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants