[V2] Added "attunement_detail" to Item model
#836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
"attunement_detail"field toItemmodel. The purpose of this new field is to capture additional contextual information about a magic items attunement requirement (ie. a Holy Avenger can only to attuned to by a Paladin).Additionally
srd-2014andsrd-2024magic items source data was updated to include relevant"attunement_detail"s where relevant.Related Issue
Closes #834
How was this tested
pytest(all passing after tests updated to reflect that the/itemendpoint now returns the"attunement_detail"field)