Skip to content

Consolidate numpy conversion functions #368

@dfulu

Description

@dfulu

Currently we have a whole suite of numpy conversion functions in the numpy_sample module. In the samplers we convert each modality into a dictionary separately and then merge the dictionaries.

I think it could be cleaner to create a single function which replaces all the numpy conversion functions in the numpy_sample module. As part of this I would also suggest that we should remove all of the {X}SampleKey classes scattered throughout the numpy_sample module. Instead all of the keys of the returned dictionary would be obvious from the new single numpy conversion function.

The new conversion function could accept a dictionary of xarray objects identical to the dictionary we pass around inside the PVNet Dataset classes to slice time and space components. We'd need to decide a little more on how to add t0, the time encodings and the solar coords to the sample, but I feel like this should be reasonably straight forward

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions