Skip to content
This repository was archived by the owner on Apr 29, 2025. It is now read-only.
This repository was archived by the owner on Apr 29, 2025. It is now read-only.

[BUG]: For bike-rentals, more than the aws-bucket-name needs to be changed to test S3 #174

@adelton

Description

@adelton

Details

Describe the bug

The #112 changed the default parameters in build-container-image-pipelinerun-bike-rentals.yaml to fetch from git but the section https://github.com/opendatahub-io/ai-edge/blob/main/pipelines/README.md#for-s3-fetch still says

Update the aws-bucket-name parameter value from its default rhoai-edge-models in build-container-image-pipelinerun-bike-rentals.yaml and/or build-container-image-pipelinerun-tensorflow-housing.yaml to match your S3 bucket name.

To Reproduce

Follow the https://github.com/opendatahub-io/ai-edge/blob/main/pipelines/README.md and try to fetch from S3 by only changing the aws-bucket-name.

The PipelineRun will still show that git-clone-model-repo was run.

Expected behavior

The documentation should be clear about what the repository demonstrates out of box, with minimal changes, and how to achieve the alternate behaviour.

Screenshots (if applicable)

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working

    Type

    No type

    Projects

    Status

    Untriaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions