Use SSL context/params in RPP for HTTPS #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Vieira <[email protected]>
danielezonca
approved these changes
Jul 11, 2024
danielezonca
left a comment
danielezonca
left a comment
There was a problem hiding this comment.
lgtm
We should add support for self signed certificates too (probably with another PR)
|
/ok-to-test |
israel-hdez
approved these changes
Jul 11, 2024
israel-hdez
left a comment
israel-hdez
left a comment
There was a problem hiding this comment.
We do not have CI for this branch yet....
But the upstream PR passed CI. Quickly scanning the code, I don't see anything risky here.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielezonca, israel-hdez, ruivieira The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spolti
pushed a commit
to spolti/modelmesh
that referenced
this pull request
Mar 5, 2025
…t-63-cp_fix_build_version Revert "[Cherry-pick]fix build-version issue"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of kserve#131.
Motivation
Need to better support remote payload processing in terms of secure connections.
Modifications
We allow injecting SSLContext (with SSLParameters) into RemotePayloadProcessor's HttpClient.
Result
Supporting sending payloads to remote endpoints over HTTPS.