Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 28, 2025

Hi all,

This pull request contains a backport of commit b3e63aea from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 28 Oct 2025 and was reviewed by William Kemper.

Thanks!


Progress

  • JDK-8370649 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/343/head:pull/343
$ git checkout pull/343

Update a local copy of the PR:
$ git checkout pull/343
$ git pull https://git.openjdk.org/jdk25u.git pull/343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 343

View PR using the GUI difftool:
$ git pr show -t 343

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/343.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b3e63aeab304016b9b479a05f44ed1c8dfb0b9bb 8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

GHA report serviceability/jvmti/RedefineClasses/ClassVersionAfterRedefine.java fails on linux-x64. It's jtreg bug which has been recorded by https://bugs.openjdk.org/browse/CODETOOLS-7904109. It's unrelated to this backport PR,

/approval request Clean backport to add '@Intermittent' tag for make some test infrasture disable or rerun this test automaticly when it's intermittent fails. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@sendaoYan
8370649: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant