-
Notifications
You must be signed in to change notification settings - Fork 112
8371094: --mac-signing-key-user-name no longer works #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8371094: --mac-signing-key-user-name no longer works #366
Conversation
Reviewed-by: almatvee
|
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
|
@alexeysemenyukoracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@aivanov-jdk please review |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request |
|
@alexeysemenyukoracle |
aivanov-jdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and the Skara bot has marked the PR as clean.
|
/integrate |
|
@alexeysemenyukoracle |
|
/sponsor |
|
Going to push as commit 8fd9a73.
Your commit was automatically rebased without conflicts. |
|
@aivanov-jdk @alexeysemenyukoracle Pushed as commit 8fd9a73. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Almost clean backport of openjdk/jdk#28120 PR with trivial conflict resolution.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/366/head:pull/366$ git checkout pull/366Update a local copy of the PR:
$ git checkout pull/366$ git pull https://git.openjdk.org/jdk25u.git pull/366/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 366View PR using the GUI difftool:
$ git pr show -t 366Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/366.diff
Using Webrev
Link to Webrev Comment