Skip to content

Commit 27b116b

Browse files
Add security provider earlier in the bootstrap process
Signed-off-by: Terry Quigley <[email protected]>
1 parent b7878c6 commit 27b116b

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2441,17 +2441,6 @@ public Optional<SecureSettingsFactory> getSecureSettingFactory(Settings settings
24412441
);
24422442
}
24432443

2444-
@SuppressWarnings("removal")
2445-
private void tryAddSecurityProvider() {
2446-
AccessController.doPrivileged((PrivilegedAction<Object>) () -> {
2447-
if (Security.getProvider("BCFIPS") == null) {
2448-
Security.addProvider(new BouncyCastleFipsProvider());
2449-
log.debug("Bouncy Castle FIPS Provider added");
2450-
}
2451-
return null;
2452-
});
2453-
}
2454-
24552444
// CS-SUPPRESS-SINGLE: RegexpSingleline get Resource Sharing Extensions
24562445
@Override
24572446
public void loadExtensions(ExtensionLoader loader) {

src/main/java/org/opensearch/security/ssl/OpenSearchSecuritySSLPlugin.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.nio.file.Path;
2121
import java.security.AccessController;
2222
import java.security.PrivilegedAction;
23+
import java.security.Security;
2324
import java.util.ArrayList;
2425
import java.util.Collection;
2526
import java.util.Collections;
@@ -35,6 +36,7 @@
3536
import org.apache.logging.log4j.LogManager;
3637
import org.apache.logging.log4j.Logger;
3738

39+
import org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider;
3840
import org.opensearch.OpenSearchException;
3941
import org.opensearch.SpecialPermission;
4042
import org.opensearch.Version;
@@ -256,6 +258,8 @@ public Object run() {
256258
log.error("SSL not activated for http and/or transport.");
257259
}
258260

261+
tryAddSecurityProvider();
262+
259263
this.sslSettingsManager = new SslSettingsManager(new Environment(settings, configPath));
260264
}
261265

@@ -772,4 +776,15 @@ protected Settings migrateSettings(Settings settings) {
772776
public ThreadPool getThreadPool() {
773777
return this.threadPool;
774778
}
779+
780+
@SuppressWarnings("removal")
781+
protected void tryAddSecurityProvider() {
782+
AccessController.doPrivileged((PrivilegedAction<Object>) () -> {
783+
if (Security.getProvider("BCFIPS") == null) {
784+
Security.addProvider(new BouncyCastleFipsProvider());
785+
log.debug("Bouncy Castle FIPS Provider added");
786+
}
787+
return null;
788+
});
789+
}
775790
}

0 commit comments

Comments
 (0)