Oppiabot is saying that contributors can't merge PRs, when they can.

[seanlip]

Describe the bug

On oppia/oppia#12620 (comment), Oppiabot is saying:

"Hi @aks681, this PR is ready to be merged. Author of this PR does not have permissions to merge this PR. Before you merge it, please make sure that there are no pending comments that require action from the author's end. Thanks!"

However, this PR is authored by Rijuta, who is a member of the Oppia organization and does indeed have permissions to merge PRs. So, this seems like a bug with Oppiabot.

Observed behavior
Oppiabot posts the following message erroneously: "Hi @aks681, this PR is ready to be merged. Author of this PR does not have permissions to merge this PR. Before you merge it, please make sure that there are no pending comments that require action from the author's end. Thanks!"

Expected behavior
Oppiabot should not post this message because the PR author has permissions to merge the PR.

[Mayank77maruti]

I have identified that the referenced message no longer exists in the Oppiabot codebase. This removal occurred as part of the following commit:

80eb0f2#diff-5c3e6c40b35fd444459b7bb6c629ddd1ac358ec4eb79f9f341c7a60899d63e66

Previously, this message was located in the spec/checkPullRequestReviewSpec.js file:

Current Code

Now, the relevant section of the code looks as follows:

// Check if author can merge PR. All members can merge the pull request.
const authorCanMerge = await utilityModule.hasMergePrivilege(
  context, pullRequest.user.login
);

let commentBody;
if (authorCanMerge) {
  // Ping and assign author.
  commentBody =
    'Hi @' +
    pullRequest.user.login +
    ', this PR is ready to be merged. Please address any remaining ' +
    'comments prior to merging, and feel free to merge this PR ' +
    "once the CI checks pass and you're happy with it. Thanks!";
} else {
  // Ping and assign author.
  commentBody =
    'Hi @' + pullRequest.user.login + ', this PR is ready to be merged. ' +
    'Please address any remaining comments prior to merging, and feel free ' +
    'to ask someone to merge your PR once the CI checks pass and ' +
    'you\'re happy with it. Thanks!';
}

Observations

The if and else blocks appear almost identical. Ideally, there should be a difference to avoid redundancy.

---