Skip to content

Conversation

@PascalBourdier
Copy link
Contributor

@PascalBourdier PascalBourdier commented Sep 16, 2025

follow this best practice: https://go.dev/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One oversight I noticed.

@PascalBourdier PascalBourdier requested a review from alnr November 26, 2025 09:03
Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CI is borked once again, don't know whats up there.

@alnr alnr enabled auto-merge (squash) November 26, 2025 20:01
@alnr
Copy link
Contributor

alnr commented Nov 26, 2025

Please rebase onto master once #621 is merged (fixes CI).

auto-merge was automatically disabled November 27, 2025 08:41

Head branch was pushed to by a user without write access

@alnr alnr merged commit e7d0374 into ory:v3 Nov 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants