Fixes for composer #631
Draft
Fixes for composer #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <[email protected]>
pombredanne
requested changes
Dec 4, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
@prabhu Thanks. I feel this may be moot after all based on the comments below? Please check!
| }, | ||
| "version_definition": { | ||
| "native_name": "version" | ||
| "requirement": "required", |
Member
There was a problem hiding this comment.
Versions are never required per spec.
| "note": "The namespace is the vendor. The namespace is not case sensitive and must be lowercased." | ||
| "note": "The namespace is the vendor. The namespace is not case sensitive and must be lowercased.", | ||
| "normalization_rules": [ | ||
| "It is not case sensitive and must be lowercased." |
Member
There was a problem hiding this comment.
This is redundant with the "case_sensitive" flag IMHO that implies lowercasing?
| "note": "The name is not case sensitive and must be lowercased. Private, local packages may have no name. In this case you cannot create a purl for these." | ||
| "note": "The name is not case sensitive and must be lowercased. Private, local packages may have no name. In this case you cannot create a purl for these.", | ||
| "normalization_rules": [ | ||
| "It is not case sensitive and must be lowercased." |
Member
There was a problem hiding this comment.
This is redundant with the "case_sensitive" flag IMHO that implies lowercasing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the frontier models and I can answer the question about whether the version is mandatory or not for composer! I'm assuming it is mandatory. All the tests include version, so reinforces the view that the version is mandatory.