Skip to content

Conversation

@LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Nov 7, 2025

Short description

This pull request introduces a more robust mechanism for detecting external deep links and triggering wallet updates in response. The primary focus is on ensuring that when users interact with specific deep links (such as those related to wallet, payment, idpay, or cgn), the wallet state is refreshed automatically in both navigation and saga flows.

List of changes proposed in this pull request

  • Improved wallet update logic by introducing checks for Universal/App Links and specific internal paths, triggering wallet updates when necessary both in saga handling and navigation subscription
  • Cleaned up navigation initialization by removing redundant code and ensuring linking subscriptions correctly handle wallet updates and URL storage.
  • Registered the new wallet saga and ensured all sagas are loaded in the correct order in
  • Removing duplicate or misplaced saga registrations.

How to test

Ensure that API calls are not triggered at startup saga and deep links are working as before

Preview

Default Wallet deeplink CGN deeplink Deeplink w/o CGN
Screen.Recording.2025-11-11.at.16.32.24.mov
Screen.Recording.2025-11-11.at.16.26.05.mov
Screen.Recording.2025-11-11.at.16.27.50.mov
Screen.Recording.2025-11-11.at.16.28.58.mov

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (e2808a6) to head (f1327d3).

Files with missing lines Patch % Lines
ts/features/linking/sagas/index.ts 20.00% 4 Missing ⚠️
ts/navigation/linkingSubscription.ts 50.00% 1 Missing ⚠️
ts/sagas/backgroundActions.ts 85.71% 1 Missing ⚠️
ts/utils/deepLinkUtils.ts 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7588   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files        1886     1888    +2     
  Lines       41112    41115    +3     
  Branches     9539     9460   -79     
=======================================
+ Hits        24754    24758    +4     
+ Misses      16282    16281    -1     
  Partials       76       76           
Files with missing lines Coverage Δ
ts/features/identification/sagas/index.ts 92.30% <ø> (ø)
ts/features/pushNotifications/sagas/common.ts 95.45% <ø> (+4.82%) ⬆️
ts/features/wallet/saga/handleWalletUpdateSaga.ts 0.00% <ø> (ø)
ts/navigation/AppStackNavigator.tsx 48.14% <ø> (+4.08%) ⬆️
ts/sagas/index.ts 0.00% <ø> (ø)
ts/sagas/startup.ts 38.06% <ø> (+0.24%) ⬆️
ts/sagas/startup/watchApplicationActivitySaga.ts 0.00% <ø> (ø)
ts/navigation/linkingSubscription.ts 94.44% <50.00%> (-5.56%) ⬇️
ts/sagas/backgroundActions.ts 85.71% <85.71%> (ø)
ts/utils/deepLinkUtils.ts 80.00% <80.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2808a6...f1327d3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants