Skip to content

Eric Chen fixed letsdrill.rb to execute as intended #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Eric Chen fixed letsdrill.rb to execute as intended #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions letsdrill.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,30 @@
def get_letter_grade(integer)

#Put your code here!

end
if integer >= 90
return "A"
Copy link

@djlax805 djlax805 Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, few quick things.

  1. In Ruby you do not need an explicit return it will return the last evaluated line of code in the block.

  2. Sometimes conditionals can grow pretty quick and get ugly, what would be your next steps to refactor this logic?

elsif integer >= 80
return "B"
elsif integer >= 70
return "C"
end

def shortest_string(array)

#Put your code here!

end


def shortest_string(array)
return array.min{|a,b| a.size <=> b.size}
end



### Don't touch anything below this line ###

p "Fetch Letter Grade: You should have 2 trues"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p
p "Shortest String: You should have 3 trues"
p shortest_string(["touch","this", "car"]) == "car"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"