GH1409 Improve Series.to_numpy typing #1476
Merged
+164
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Seems like I should be able to restrict some of the types. |
cmp0xff
requested changes
Nov 10, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
One comment to fix the warning on Windows. Others are just ideas.
cmp0xff
added
Compat
cmp0xff
requested changes
Nov 11, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
- We need to use
np_1darray_xxxin the stubs. I'll deal with the tests later in #1478. s8remains to be renamed.
Otherwise looking good!
cmp0xff
approved these changes
Nov 11, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you @loicdiridollou !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_numpydoes not reflectS1inpd.Series[S1]#1409assert_type()to assert the type of any return valueShould address the most general case for each type, happy to improve with the dtype parameter, from experience this is not used a lot but let me know, good to restrict some of those types.