Commit 03d0c5f
authored
Revert unnecessary runtime check for valid Python interpreter (#7451)
### Problem
Pants developers run Pants differently than end users do. Whereas they either download the wheel from PyPi or use a Pex, developers build from source. This allows us to run Pants with any Python version we'd like.
Due to a misunderstanding thinking this meant end users could also run Pants with any Python interpreter they wanted, we added in #7365 a runtime check to ensure they use 2.7 or 3.6+.
However, we realized it is impossible (or at least extremely unlikely) that end users will run Pants with an invalid interpreter, due to install time checks, as follows:
* Pip will not resolve for invalid interpreters like 3.5, as it will not be able to find a valid wheel.
* Pex includes interpreter constraints when being built, so the Pex cannot be ran with an invalid interpreter.
Thus, the runtime check is unnecessary.
### Solution
Remove the runtime check.
### Result
Less code and slightly faster performance due to one less check.1 parent 4a6fc72 commit 03d0c5f
File tree
3 files changed
+0
-76
lines changed- src/python/pants/bin
- tests/python/pants_test/bin
3 files changed
+0
-76
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
23 | | - | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
27 | 25 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | 26 | | |
37 | 27 | | |
38 | 28 | | |
| |||
72 | 62 | | |
73 | 63 | | |
74 | 64 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | 65 | | |
97 | 66 | | |
98 | 67 | | |
| |||
109 | 78 | | |
110 | 79 | | |
111 | 80 | | |
112 | | - | |
113 | 81 | | |
114 | 82 | | |
115 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 4 | | |
13 | 5 | | |
14 | | - | |
15 | | - | |
16 | 6 | | |
17 | 7 | | |
18 | 8 | | |
| |||
This file was deleted.
0 commit comments