build: fixes for newer Rust #146
Conversation
|
@hug-dev hopefully this makes CI pass on both MSRV and current, could you please approve the workflow to run? Thank you! |
hug-dev
left a comment
hug-dev
left a comment
There was a problem hiding this comment.
Thanks a lot for taking care of this repo ❤️
Will see who else could review it
|
Thanks! It seems I missed this part when testing locally: I don't have mbedtls on the host system and have excluded those parts of CI. Will revisit using a container to execute all parts. Sorry for missing this. I'll most likely take care of that later this week or weekend. |
dsseng
force-pushed
the
modern-rust-fixes
branch
from
8c5bb3b to
a4b7ee3
Compare
|
@hug-dev sorry for taking a long time to apply a fix, hopefully it all passes now, at least locally |
|
One last error 😢 |
Adapt newest best practices according to Clippy, fix compiler warnings. Also build mbedTLS concurrently for faster CI builds. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
force-pushed
the
modern-rust-fixes
branch
from
a4b7ee3 to
8b8cf73
Compare
Sorry, fixed that now! This way the source should satisfy both the type constraints of 1.66 and stricter Clippy rules of 1.91 |
2 participants
Adapt newest best practices according to Clippy, fix compiler warnings.
Also build mbedTLS concurrently for faster CI builds.
Signed-off-by: Dmitrii Sharshakov [email protected]