Skip to content

Email HTML should be passed in request body not in URI string #43

@jeffpe

Description

@jeffpe

Ok seems like this was addressed in previous issue from years ago:
https://github.com/Pardot/ruby-pardot/blob/master/lib/pardot/http.rb#L19


If the html content of an email is passed in the URI string, as the gem does, it is limited in length. The gem will fail when this occurs as it does not recognize the error and generates a NIL Error (undefined method '[]' for nil:nilClass in emails.rb:37 from emails.rb:25 ).

Gem should be altered to pass email html in the body of the http request. Note other parameters could be passed this way as well.

Interestingly the Pardot API does return the error in the return URI string (HTTP 414 URI Too Long ) but the gem does not recognize these errors.

I patched with a few quick conditionals. Looks like better fix was posted.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions