[stable2509] Backport #10362: net/peerset: Optimize substream opening duration for SetReservedPeers
#10408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` (#10362) While triaging the Versi-net, I've discovered that the connection between collators and validators sometimes takes less than 20ms, while at other times it takes more than 500ms. In both cases, the validators are already connected to a different protocol. Therefore, opening and negotiating substreams must be almost instant. The slot timer of the peerset artificially introduces the delay: - The `SetReservedPeers` is received by the peerset. At this step, the peerset propagated the `closedSubstream` to signal that it wants to disconnect previously reserved peers. - At the next slot allocation timer tick (after 1s), the newly added reserved peers are requested to be connected This can introduce an artificial delay of up to 1s, which is unnecessary. To mitigate this behavior, this PR: - Transforms the ` enum PeersetNotificationCommand` into a structure. Effectively, the peerset can specify directly to close some substreams and open other substreams - Upon receiving the `SetReservedPeers` command, peers are moved into the `Opening` state and the request is propagated to the litep2p to open substreams. - The behavior of the slot allocation timer remains identical. This is needed to capture the following edge cases: - The reserved peer of the `SetReservedPeers` is not disconnected, but backoff / pending closing. - The reserved peer is banned cc @paritytech/networking Detected during versi-net triaging of elastic scaling: #10310 (comment) --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]> (cherry picked from commit 8a034ca)
github-actions
bot
added
the
A3-backport
Contributor
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
lexnv
approved these changes
Nov 25, 2025
lexnv
changed the title
SetReservedPeers
smohan-dw
pushed a commit
to dhiway/sdk
that referenced
this pull request
Nov 28, 2025
…am opening duration for `SetReservedPeers` (paritytech#10408) Backport paritytech#10362 into `stable2509` from lexnv. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Egor_P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10362 into
stable2509from lexnv.See the documentation on how to use this bot.