#1566 Bugfix/twitter cancel continue app crash (#1567)

* Looking for Oauth and denied params

* updated test cases and removed 'and' condition  for successful redirection(made or to check for 'oauth_verifier' or 'oauth_token'

* Update Gemfile.lock

reverting gemlock

Co-authored-by: dhana <[email protected]>

Author: dsp1589

ParseTwitterUtils/ParseTwitterUtils/Internal/Dialog/PFOAuth1FlowDialog.m

@@ -414,7 +414,21 @@ - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigati
     NSURL *url = navigationAction.request.URL;
     BOOL hasPrefix = [url.absoluteString hasPrefix:self.redirectURLPrefix];
     if (hasPrefix) {
-        [self _dismissWithSuccess:YES url:url error:nil];
+        NSURLComponents* components = [[NSURLComponents alloc] initWithString:url.absoluteString];
+        NSArray<NSURLQueryItem *> * items = components.queryItems;
+        if (items) {
+            for (NSURLQueryItem * queryItem in items) {
+                if ([queryItem.name isEqualToString:@"denied"]) {
+                    [self _dismissWithSuccess:NO url:url error:nil];
+                    break;
+                } else if ([queryItem.name isEqualToString:@"oauth_verifier"] || [queryItem.name isEqualToString:@"oauth_token" ]) {
+                    [self _dismissWithSuccess:YES url:url error:nil];
+                    break;;
+                }
+            }
+        } else {
+            [self _dismissWithSuccess:NO url:url error:nil];
+        }
         decisionHandler(WKNavigationActionPolicyCancel);
         return;
     } else if (navigationAction.navigationType == UIWebViewNavigationTypeLinkClicked && [self.dataSource dialog:self shouldOpenURLInExternalBrowser:url]) {

ParseTwitterUtils/Tests/Unit/OAuth1FlowDialogTests.m

@@ -127,7 +127,8 @@ - (void)skip_testRotation {
 
 - (void)testWebViewDelegate {
     NSURL *sampleURL = [NSURL URLWithString:@"http://foo.bar"];
-    NSURL *successURL = [NSURL URLWithString:@"foo://success"];
+    NSURL *successURL = [NSURL URLWithString:@"foo://success/?oauth_verifier=abcd&oauth_token=authtoken123"];
+    NSURL *rejectedURL = [NSURL URLWithString:@"foo://success/?denied=authtoken123"];
 
     //XCTestExpectation *flowExpectation = [[XCTestExpectation alloc] initWithDescription: @"Waiting for redirect"];
     XCTestExpectation *flowExpectation = [self currentSelectorTestExpectation];
@@ -172,7 +173,22 @@ - (void)testWebViewDelegate {
         [canceledExpectation fulfill];
     }];
 
-    [self waitForExpectations:@[policyExpectation, flowExpectation, canceledExpectation] timeout:20];
+    XCTestExpectation *canceledOnDeniedExpectation = [[XCTestExpectation alloc] initWithDescription:@"Waiting for canceled policy decision"];
+    
+    WKNavigation* rejectNavigation = (WKNavigation *)([[NSObject alloc] init]);
+    [flowDialog webView:webView didStartProvisionalNavigation:rejectNavigation];
+    [flowDialog webView:webView didFinishNavigation:rejectNavigation];
+    
+    FakeWKNavigationAction *rejectAction = [[FakeWKNavigationAction alloc] init];
+    rejectAction.navigationType = WKNavigationTypeOther;
+    rejectAction.request = [NSURLRequest requestWithURL:rejectedURL];
+    
+    [flowDialog webView:webView decidePolicyForNavigationAction:rejectAction decisionHandler:^(WKNavigationActionPolicy policy) {
+        XCTAssertTrue(policy == WKNavigationActionPolicyCancel);
+        [canceledOnDeniedExpectation fulfill];
+    }];
+    
+    [self waitForExpectations:@[policyExpectation, flowExpectation, canceledExpectation, canceledOnDeniedExpectation] timeout:20];
 }
 
 @end