Fix: Skip the non-exist namespaces when there are multiple mongo instance metrics to scrape

Signed-off-by: LinPr <[email protected]>

Author: LinPr

exporter/collstats_collector.go

@@ -78,7 +78,7 @@ func (d *collstatsCollector) collect(ch chan<- prometheus.Metric) {
 		collections = fromMapToSlice(onlyCollectionsNamespaces)
 	} else {
 		var err error
-		collections, err = checkNamespacesForViews(d.ctx, client, d.collections)
+		collections, err = checkNamespacesForViewsOrNonExist(d.ctx, client, d.collections, logger)
 		if err != nil {
 			logger.Error("cannot list collections", "error", err.Error())
 			return

exporter/common.go

@@ -18,6 +18,7 @@ package exporter
 import (
 	"context"
 	"fmt"
+	"log/slog"
 	"sort"
 	"strings"
 
@@ -163,7 +164,7 @@ func unique(slice []string) []string {
 	return list
 }
 
-func checkNamespacesForViews(ctx context.Context, client *mongo.Client, collections []string) ([]string, error) {
+func checkNamespacesForViewsOrNonExist(ctx context.Context, client *mongo.Client, collections []string, logger *slog.Logger) ([]string, error) {
 	onlyCollectionsNamespaces, err := listAllCollections(ctx, client, collections, nil, true)
 	if err != nil {
 		return nil, err
@@ -183,6 +184,9 @@ func checkNamespacesForViews(ctx context.Context, client *mongo.Client, collecti
 		}
 
 		if _, ok := namespaces[collection]; !ok {
+			if logger != nil {
+				logger.Warn("namespace is a view or does not exist, cannot be used for collstats/indexstats", "namespace", collection)
+			}
 			continue
 		}
 

exporter/common_test.go

@@ -198,14 +198,14 @@ func TestCheckNamespacesForViews(t *testing.T) {
 	setupDB(ctx, t, client)
 	defer cleanupDB(ctx, client)
 
-	t.Run("Views in provided collection list (should fail)", func(t *testing.T) {
-		filtered, err := checkNamespacesForViews(ctx, client, []string{"testdb01.col01", "testdb01.system.views", "testdb01.view01"})
+	t.Run("Views or non-exist namespace in provided collection list (should fail)", func(t *testing.T) {
+		filtered, err := checkNamespacesForViewsOrNonExist(ctx, client, []string{"testdb01.col01", "testdb01.system.views", "testdb01.non_existent"}, nil)
 		assert.NoError(t, err)
-		assert.Equal(t, []string{"testdb01.col01", "testdb01.system.views"}, filtered)
+		assert.Equal(t, []string{"testdb01.col01"}, filtered)
 	})
 
 	t.Run("No Views in provided collection list", func(t *testing.T) {
-		filtered, err := checkNamespacesForViews(ctx, client, []string{"testdb01.col01", "testdb01.system.views"})
+		filtered, err := checkNamespacesForViewsOrNonExist(ctx, client, []string{"testdb01.col01", "testdb01.system.views"}, nil)
 		assert.NoError(t, err)
 		assert.Equal(t, []string{"testdb01.col01", "testdb01.system.views"}, filtered)
 	})

exporter/indexstats_collector.go

@@ -77,7 +77,7 @@ func (d *indexstatsCollector) collect(ch chan<- prometheus.Metric) {
 		collections = fromMapToSlice(onlyCollectionsNamespaces)
 	} else {
 		var err error
-		collections, err = checkNamespacesForViews(d.ctx, client, d.collections)
+		collections, err = checkNamespacesForViewsOrNonExist(d.ctx, client, d.collections, logger)
 		if err != nil {
 			logger.Error("cannot list collections", "error", err.Error())