Update rubocop to 1.71, rubocop-rspec to 3.4

This also lets us drop the Ruby 3.0 requirement for rubocop on CI, since
we can now use rubocop on all released Ruby versions.

Further, turn off some of the newly introduced cops that seem to add
unnecessary noise, and opt in to new cops by default (this avoids a
warning, and seems fine since we lock the rubocop version).

Also, drop inline disabling of the "Lint/EmptyWhen" lint, which is no
longer needed.

Author: lfittl

.github/workflows/ci.yml

@@ -28,4 +28,3 @@ jobs:
       run: bundle exec rake test
     - name: RuboCop
       run: bundle exec rake lint
-      if:  matrix.ruby == '3.0'

.rubocop.yml

@@ -1,6 +1,7 @@
 require: rubocop-rspec
 
 AllCops:
+  NewCops: enable
   Exclude:
     - ext/pg_query/extconf.rb
     - vendor/**/*
@@ -9,46 +10,59 @@ AllCops:
     - lib/pg_query/json_field_names.rb
     - Rakefile
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Exclude:
     - spec/**/*
 
-Style/WordArray:
+Layout/SpaceAroundOperators:
   Exclude:
     - spec/**/*
 
-Style/StringLiterals:
+Layout/SpaceInsideHashLiteralBraces:
   Exclude:
     - spec/**/*
 
-Layout/SpaceAroundOperators:
+Style/WordArray:
   Exclude:
     - spec/**/*
 
-Layout/SpaceInsideHashLiteralBraces:
+Style/StringLiterals:
   Exclude:
     - spec/**/*
 
-Performance/RegexpMatch:
-  Exclude:
-    - ext/pg_query/extconf.rb
+Layout/LineLength:
+  Enabled: false
+
+Layout/EmptyLineAfterGuardClause:
+  Enabled: false
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  Enabled: false
 
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 Style/SafeNavigation:
   Enabled: false
 
-Documentation:
+Style/Documentation:
   Enabled: false
 
-LineLength:
+# extend self preserves private methods,
+# module_function buggily removes them.
+Style/ModuleFunction:
   Enabled: false
 
-MethodLength:
+Metrics/MethodLength:
   Enabled: false
 
-ClassLength:
+Metrics/ClassLength:
   Enabled: false
 
 Metrics/AbcSize:
@@ -75,9 +89,16 @@ RSpec/NestedGroups:
 RSpec/DescribedClass:
   Enabled: false
 
-# extend self preserves private methods,
-# module_function buggily removes them.
-Style/ModuleFunction:
+RSpec/ContextWording:
+  Enabled: false
+
+RSpec/MatchArray:
+  Enabled: false
+
+RSpec/NamedSubject:
+  Enabled: false
+
+RSpec/SpecFilePathFormat:
   Enabled: false
 
 Lint/ImplicitStringConcatenation:

Gemfile

@@ -4,6 +4,6 @@ gemspec
 
 gem 'rake-compiler', '~> 0'
 gem 'rspec', '~> 3.0'
-gem 'rubocop', '0.49.1'
-gem 'rubocop-rspec', '1.15.1'
+gem 'rubocop', '~> 1.71'
+gem 'rubocop-rspec', '~> 3.4'
 gem 'simplecov', '~> 0'

Gemfile.lock

@@ -14,15 +14,18 @@ GEM
     google-protobuf (4.29.3)
       bigdecimal
       rake (>= 13)
+    json (2.9.1)
+    language_server-protocol (3.17.0.4)
     parallel (1.26.3)
-    parser (2.7.2.0)
+    parser (3.3.7.0)
       ast (~> 2.4.1)
-    powerpack (0.1.3)
-    rainbow (2.2.2)
-      rake
+      racc
+    racc (1.8.1)
+    rainbow (3.1.1)
     rake (13.2.1)
     rake-compiler (0.9.9)
       rake
+    regexp_parser (2.10.0)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -36,23 +39,30 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (0.49.1)
+    rubocop (1.71.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 2.3.3.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    rubocop-rspec (1.15.1)
-      rubocop (>= 0.42.0)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.38.0)
+      parser (>= 3.3.1.0)
+    rubocop-rspec (3.4.0)
+      rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    unicode-display_width (1.8.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
 
 PLATFORMS
   ruby
@@ -61,8 +71,8 @@ DEPENDENCIES
   pg_query!
   rake-compiler (~> 0)
   rspec (~> 3.0)
-  rubocop (= 0.49.1)
-  rubocop-rspec (= 1.15.1)
+  rubocop (~> 1.71)
+  rubocop-rspec (~> 3.4)
   simplecov (~> 0)
 
 BUNDLED WITH

lib/pg_query/parse.rb

@@ -174,7 +174,7 @@ def load_objects! # rubocop:disable Metrics/CyclomaticComplexity
           # The following statement types are DDL (changing table structure)
           when :alter_table_stmt
             case statement.alter_table_stmt.objtype
-            when :OBJECT_INDEX # Index # rubocop:disable Lint/EmptyWhen
+            when :OBJECT_INDEX # Index
               # ignore `ALTER INDEX index_name`
             else
               from_clause_items << { item: PgQuery::Node.new(range_var: statement.alter_table_stmt.relation), type: :ddl }
@@ -228,11 +228,11 @@ def load_objects! # rubocop:disable Metrics/CyclomaticComplexity
           when :grant_stmt
             objects = statement.grant_stmt.objects
             case statement.grant_stmt.objtype
-            when :OBJECT_COLUMN # Column # rubocop:disable Lint/EmptyWhen
+            when :OBJECT_COLUMN # Column
               # FIXME
             when :OBJECT_TABLE # Table
               from_clause_items += objects.map { |o| { item: o, type: :ddl } }
-            when :OBJECT_SEQUENCE # Sequence # rubocop:disable Lint/EmptyWhen
+            when :OBJECT_SEQUENCE # Sequence
               # FIXME
             end
           when :lock_stmt