Making cache tags more efficient by rewriting the API.

Nyholm · Nyholm · commit 0a3d663c8855 · 2016-02-23T09:21:14.000+01:00
Related to php-cache/issues#21
diff --git a/MongoDBCachePool.php b/MongoDBCachePool.php
@@ -73,18 +73,18 @@ protected function clearOneObjectFromCache($key)
         return true;
     }
 
-    protected function storeItemInCache($key, CacheItemInterface $item, $ttl)
+    protected function storeItemInCache(CacheItemInterface $item, $ttl)
     {
         $object = [
-            '_id'  => $key,
+            '_id'  => $item->getKey(),
             'data' => serialize($item->get()),
         ];
 
         if ($ttl) {
             $object['expiresAt'] = time() + $ttl;
         }
 
-        $this->collection->updateOne(['_id' => $key], ['$set' => $object], ['upsert' => true]);
+        $this->collection->updateOne(['_id' => $item->getKey()], ['$set' => $object], ['upsert' => true]);
 
         return true;
     }
diff --git a/Tests/IntegrationTagTest.php b/Tests/IntegrationTagTest.php
diff --git a/composer.json b/composer.json
@@ -32,7 +32,7 @@
     },
     "require-dev":       {
         "phpunit/phpunit":         "^4.0|^5.1",
-        "cache/integration-tests": "0.7.0"
+        "cache/integration-tests": "0.9.0"
     },
     "provide":           {
         "psr/cache-implementation": "^1.0"

Original file line number	Diff line number	Diff line change
`@@ -73,18 +73,18 @@ protected function clearOneObjectFromCache($key)`
`73`	`73`	`return true;`
`74`	`74`	`}`
`75`	`75`
`76`		`- protected function storeItemInCache($key, CacheItemInterface $item, $ttl)`
	`76`	`+ protected function storeItemInCache(CacheItemInterface $item, $ttl)`
`77`	`77`	`{`
`78`	`78`	`$object = [`
`79`		`- '_id' => $key,`
	`79`	`+ '_id' => $item->getKey(),`
`80`	`80`	`'data' => serialize($item->get()),`
`81`	`81`	`];`
`82`	`82`
`83`	`83`	`if ($ttl) {`
`84`	`84`	`$object['expiresAt'] = time() + $ttl;`
`85`	`85`	`}`
`86`	`86`
`87`		`- $this->collection->updateOne(['_id' => $key], ['$set' => $object], ['upsert' => true]);`
	`87`	`+ $this->collection->updateOne(['_id' => $item->getKey()], ['$set' => $object], ['upsert' => true]);`
`88`	`88`
`89`	`89`	`return true;`
`90`	`90`	`}`