Fixed build CREATE TABLE query with PARTITIONS having ENGINE but not VALUES.

Fixes #174

Signed-off-by: Michal Čihař <[email protected]>

Author: nijel

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [Unreleased]
 
 * Make mbstring extension optional (though Symfony polyfill).
+* Fixed build CREATE TABLE query with PARTITIONS having ENGINE but not VALUES.
 
 ## [4.2.2] - 2017-09-28
 

src/Components/PartitionDefinition.php

@@ -214,7 +214,7 @@ public static function build($component, array $options = array())
         return trim(
             'PARTITION ' . $component->name
             . (empty($component->type) ? '' : ' VALUES ' . $component->type . ' ' . $component->expr . ' ')
-            . $component->options . $subpartitions
+            . ((!empty($component->options) && !empty($component->type)) ? '' : ' ') . $component->options . $subpartitions
         );
     }
 }

tests/Builder/CreateStatementTest.php

@@ -183,9 +183,11 @@ public function testBuilderPartitions()
         $this->assertEquals($query, $parser->statements[0]->build());
     }
 
-    public function testBuilderPartitionsEngine()
+    public function partitionQueries()
     {
-        $query = <<<EOT
+        return array(
+            array(
+                'subparts' => <<<EOT
 CREATE TABLE `ts` (
   `id` int(11) DEFAULT NULL,
   `purchased` date DEFAULT NULL
@@ -206,7 +208,33 @@ public function testBuilderPartitionsEngine()
 SUBPARTITION s5 ENGINE=InnoDB
 )
 )
-EOT;
+EOT
+            ),
+            array(
+                'parts' => <<<EOT
+CREATE TABLE ptest (
+  `event_date` date NOT NULL
+) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=DYNAMIC
+PARTITION BY HASH (TO_DAYS(event_date))
+(
+PARTITION p0 ENGINE=InnoDB,
+PARTITION p1 ENGINE=InnoDB,
+PARTITION p2 ENGINE=InnoDB,
+PARTITION p3 ENGINE=InnoDB,
+PARTITION p4 ENGINE=InnoDB
+)
+EOT
+            ),
+        );
+    }
+
+    /**
+     * @dataProvider partitionQueries
+     *
+     * @param string $query
+     */
+    public function testBuilderPartitionsEngine($query)
+    {
         $parser = new Parser($query);
         $stmt = $parser->statements[0];