Skip to content

rings const part_chords #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rings const part_chords #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rings/dsp/part.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ void Part::ConfigureResonators() {
#ifdef BRYAN_CHORDS

// Chord table by Bryan Noll:
float chords[kMaxPolyphony][11][8] = {
const float part_chords[kMaxPolyphony][11][8] = {
{
{ -12.0f, -0.01f, 0.0f, 0.01f, 0.02f, 11.98f, 11.99f, 12.0f }, // OCT
{ -12.0f, -5.0f, 0.0f, 6.99f, 7.0f, 11.99f, 12.0f, 19.0f }, // 5
Expand Down Expand Up @@ -182,7 +182,7 @@ float chords[kMaxPolyphony][11][8] = {
#else

// Original chord table
float chords[kMaxPolyphony][11][8] = {
const float part_chords[kMaxPolyphony][11][8] = {
{
{ -12.0f, 0.0f, 0.01f, 0.02f, 0.03f, 11.98f, 11.99f, 12.0f },
{ -12.0f, 0.0f, 3.0f, 3.01f, 7.0f, 9.99f, 10.0f, 19.0f },
Expand Down Expand Up @@ -265,7 +265,7 @@ void Part::ComputeSympatheticStringsNotes(
if (parameter >= 2.0f) {
// Quantized chords
int32_t chord_index = parameter - 2.0f;
const float* chord = chords[polyphony_ - 1][chord_index];
const float* chord = part_chords[polyphony_ - 1][chord_index];
for (size_t i = 0; i < num_strings; ++i) {
destination[i] = chord[i] + note;
}
Expand Down