Enable `flake8-logging-format` rule in Ruff

[jnptk]

Hi,

Today I learned about the flake8-logging-format (see: https://docs.astral.sh/ruff/rules/logging-f-string/) rule, which helps prevent using f-strings in logging calls.

It encourages using format arguments like:

logger.info("User %s logged in", user)

instead of f-strings, avoiding unnecessary string interpolation, improving logging consistency and following Python’s logging best practices.

Would it make sense to enable this rule in Plone’s Ruff setup?
If so, I’d be happy to open a PR to add it.

[davisagli]

@jnptk Interesting, I wasn't aware that this was a best practice. It does make sense that it could avoid a bit of unnecessary work in cases when the log is not actually output anywhere. On the other hand, the extra overhead is probably tiny and I find f-strings nicer to write and read.

I'm +0 on this, i.e. I don't have a strong opinion.

[ale-rt]

I am +1 in having that rule ❤️

That is one remark I always do when doing PR reviews.

This is also something that makes pylint happy, see https://pylint.readthedocs.io/en/stable/user_guide/messages/warning/logging-fstring-interpolation.html

If you look around, you will find some style guides that expect that logging format, see e.g.:

• https://google.github.io/styleguide/pyguide.html#3101-logging