Skip to content

Conversation

@odockal
Copy link
Contributor

@odockal odockal commented Dec 13, 2024

…tion on Mac

Fixes: #158

@odockal odockal requested a review from adrianriobo December 13, 2024 14:59
@odockal
Copy link
Contributor Author

odockal commented Dec 13, 2024

@adrianriobo Not sure about go error handling. It would be great that it works the way, that when there is no button, it wont fail to cover situations where the dialog with button simply does not appear. so the code is more universal.

@odockal odockal force-pushed the issue-158 branch 4 times, most recently from 097efee to bed40f5 Compare December 18, 2024 14:25
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not approving as it seems tests are not passing

if err := y.Click(installerAllow, delay.SMALL); err != nil {
return installerError(err)
}
// reinitilize installer app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// reinitilize installer app
// reinitilize installer app

typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer would like to access files in your Download folder dialog on Mac OS for pd-goax-e2e

2 participants