add a report

Signed-off-by: Clement Philipot <[email protected]>

Author: cphili

commons/src/main/resources/com/powsybl/commons/reports.properties

@@ -181,6 +181,7 @@ core.iidm.network.tooManyRegulatingControlEnabled = Transformer '${id}': only on
 core.iidm.network.undefinedShuntSection = Shunt compensator '${id}': the current section number is undefined
 core.iidm.network.validationWarningBothRatioPhase = Transformer '${id}' has both Ratio and Phase Tap Changer.
 core.iidm.network.validationWarningReactiveCapabilityCurveDuplicate = Reactive capability curve for ${id} has a duplicate point for active power ${p}
+core.iidm.network.validationWarningReactiveCapabilityCurveReversedMinQMaxQ = Reactive capability curve for ${id} : reversed minQ > maxQ values have been put in the right order
 core.iidm.network.voltageSetpointInvalidVoltageRegulatorOn = '${id}': voltage setpoint value (${voltageSetpoint}) is invalid (voltage regulator is on)
 core.iidm.serde.extensionNotFound = Extension ${extensionName} not found.
 core.iidm.serde.extensionsNotFound = Not found extensions

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/NetworkReports.java

@@ -57,6 +57,14 @@ public static void parentHasDuplicatePointForActivePower(ReportNode reportNode,
                 .add();
     }
 
+    public static void reactiveCapabilityCurveReversedMinQMaxQ(ReportNode reportNode, String id) {
+        reportNode.newReportNode()
+                .withMessageTemplate("core.iidm.network.validationWarningReactiveCapabilityCurveReversedMinQMaxQ")
+                .withTypedValue("id", id, TypedValue.ID)
+                .withSeverity(TypedValue.WARN_SEVERITY)
+                .add();
+    }
+
     public static ReportNode runIidmNetworkValidationCHecks(ReportNode reportNode, String networkId) {
         return Objects.requireNonNull(reportNode).newReportNode()
                 .withMessageTemplate("core.iidm.network.IIDMValidation")

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveAdderImpl.java

@@ -81,10 +81,12 @@ public ReactiveCapabilityCurveAdder endPoint() {
                 }
             }
             if (maxQ < minQ) {
-                LOGGER.warn("minQ > maxQ : values were inverted and have been put in the right order");
                 double temp = minQ;
                 minQ = maxQ;
                 maxQ = temp;
+                LOGGER.warn("minQ > maxQ : values were reversed and have been put in the right order");
+                NetworkReports.reactiveCapabilityCurveReversedMinQMaxQ(owner.getNetwork().getReportNodeContext().getReportNode(),
+                        owner.getMessageHeader().id());
             }
 
             points.put(p, new PointImpl(p, minQ, maxQ));

iidm/iidm-impl/src/test/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveImplTest.java

@@ -7,6 +7,10 @@
  */
 package com.powsybl.iidm.network.impl;
 
+import com.powsybl.commons.report.PowsyblCoreReportResourceBundle;
+import com.powsybl.commons.report.ReportNode;
+import com.powsybl.commons.test.PowsyblTestReportResourceBundle;
+import com.powsybl.commons.test.TestUtil;
 import com.powsybl.iidm.network.Generator;
 import com.powsybl.iidm.network.Network;
 import com.powsybl.iidm.network.ReactiveCapabilityCurve;
@@ -17,9 +21,13 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
+import java.io.IOException;
+import java.io.StringWriter;
 import java.util.TreeMap;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
 /**
  *
  * @author Geoffroy Jamgotchian {@literal <geoffroy.jamgotchian at rte-france.com>}
@@ -34,6 +42,13 @@ private ReactiveCapabilityCurveImpl createCurve(Point... points) {
         return new ReactiveCapabilityCurveImpl(map, "ReactiveCapabilityCurve owner");
     }
 
+    private static boolean checkReportNode(String expected, ReportNode reportNode) throws IOException {
+        StringWriter sw = new StringWriter();
+        reportNode.print(sw);
+        assertEquals(expected, TestUtil.normalizeLineSeparator(sw.toString()));
+        return true;
+    }
+
     @Test
     void testReactiveCapabilityCurve() {
         ReactiveCapabilityCurveImpl curve = createCurve(new PointImpl(100.0, 200.0, 300.0),
@@ -58,9 +73,16 @@ void testReactiveCapabilityCurve() {
     }
 
     @Test
-    void testReactiveCapabilityCurveWithInvertedMinQMaxQ() {
+    void testReactiveCapabilityCurveWithInvertedMinQMaxQ() throws IOException {
 
         Network network = FictitiousSwitchFactory.create();
+
+        ReportNode reportNode = ReportNode.newRootReportNode()
+                .withResourceBundles(PowsyblTestReportResourceBundle.TEST_BASE_NAME, PowsyblCoreReportResourceBundle.BASE_NAME)
+                .withMessageTemplate("key1")
+                .build();
+        network.getReportNodeContext().pushReportNode(reportNode);
+
         Generator generator = network.getGenerator("CB");
 
         ReactiveCapabilityCurve reactiveCapabilityCurve = generator.newReactiveCapabilityCurve()
@@ -78,9 +100,11 @@ void testReactiveCapabilityCurveWithInvertedMinQMaxQ() {
 
         assertEquals(1.0, reactiveCapabilityCurve.getMinQ(1.0), 0.0);
         assertEquals(5.0, reactiveCapabilityCurve.getMaxQ(1.0), 0.0);
-        //inverted minQ and maxQ have been put in the right order :
+        // reversed minQ and maxQ values have been put in the right order :
         assertEquals(2.0, reactiveCapabilityCurve.getMinQ(100.0), 0.0);
         assertEquals(10.0, reactiveCapabilityCurve.getMaxQ(100.0), 0.0);
+        assertTrue(checkReportNode("+ name1" + System.lineSeparator() +
+                "   Reactive capability curve for CB : reversed minQ > maxQ values have been put in the right order" + System.lineSeparator(), network.getReportNodeContext().getReportNode()));
     }
 
     @ParameterizedTest