Cgmes import: handle duplicate region name #3587
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
rcourtier
force-pushed
the
fix_cgmes_import_duplicate_region_name
branch
from
c515a2c to
d551283
Compare
Signed-off-by: Romain Courtier <[email protected]>
|
marqueslanauja
approved these changes
Oct 16, 2025
github-project-automation
bot
moved this from Waiting for review
to Approved
in Release 12/2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
When CGMES input data have duplicate GeographicalRegion.rdf:Id but with different name, the CGMES import fails and throws an exception: "Substation should be null". This is due to the substations SPARQL query finding 2 Substation instead of one (1 PropertyBag with the first region name, and another PropertyBag with the second region name).
What is the new behavior (if this is a feature change)?
Only 1 Substation is returned by the SPARQL query in case of duplicate GeographicalRegion with different name. The lowest region name is kept.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
The method microGridBaseCaseDuplicateRegion() of CgmesConformity1ModifiedCatalog has been removed. It was used for unit testing, but it relied on big a CGMES file ; this slowed the tests execution. If you still need to use it you can retrieve the methods at this URL and the corresponding CGMES files in this directory.
Other information:
Original PR to fix duplicate in sub-region ids and region ids: #2507. The same logic is now applied to region name.