-
Notifications
You must be signed in to change notification settings - Fork 49
Add an option to check minQ < maxQ (reorder reverted values) #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cphili
wants to merge
10
commits into
main
Choose a base branch
from
add_check_minq_maxq
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19b2c46 to
5366d28
Compare
Signed-off-by: Clement Philipot <[email protected]>
5366d28 to
d0c2b88
Compare
geofjamg
requested changes
Nov 4, 2025
.../iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveAdderImpl.java
Outdated
Show resolved
Hide resolved
90234f3 to
c52fa89
Compare
Signed-off-by: Clement Philipot <[email protected]>
c52fa89 to
7847c7c
Compare
alicecaron
reviewed
Nov 6, 2025
commons/src/main/resources/com/powsybl/commons/reports.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
e74efb6 to
3d4df5c
Compare
alicecaron
reviewed
Nov 12, 2025
.../iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveAdderImpl.java
Outdated
Show resolved
Hide resolved
commons/src/main/resources/com/powsybl/commons/reports.properties
Outdated
Show resolved
Hide resolved
commons/src/main/resources/com/powsybl/commons/reports_fr.properties
Outdated
Show resolved
Hide resolved
…ctiveCapabilityCurveAdderImpl.java Co-authored-by: CARON Alice <[email protected]> Signed-off-by: Clement Philipot <[email protected]>
Co-authored-by: CARON Alice <[email protected]> Signed-off-by: Clement Philipot <[email protected]>
…erties Co-authored-by: CARON Alice <[email protected]> Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
…_fr.properties" Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
9d318ef to
b96248a
Compare
|
alicecaron
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#3648
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: