Skip to content

Conversation

@cphili
Copy link
Member

@cphili cphili commented Oct 20, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
#3648

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@cphili cphili self-assigned this Oct 20, 2025
@cphili cphili force-pushed the add_check_minq_maxq branch from 19b2c46 to 5366d28 Compare October 20, 2025 14:33
@cphili cphili changed the title Add a check to invert minQ>maxQ values Add a check for inverted minQ>maxQ values Oct 20, 2025
@cphili cphili changed the title Add a check for inverted minQ>maxQ values Add a check to invert minQ>maxQ values Oct 20, 2025
Signed-off-by: Clement Philipot <[email protected]>
@cphili cphili force-pushed the add_check_minq_maxq branch from 5366d28 to d0c2b88 Compare October 20, 2025 15:08
@cphili cphili changed the title Add a check to invert minQ>maxQ values Add a check for minQ>maxQ (invert values) Oct 20, 2025
@cphili cphili marked this pull request as ready for review October 20, 2025 15:09
@cphili cphili force-pushed the add_check_minq_maxq branch from 90234f3 to c52fa89 Compare November 5, 2025 15:45
Signed-off-by: Clement Philipot <[email protected]>
@cphili cphili force-pushed the add_check_minq_maxq branch from c52fa89 to 7847c7c Compare November 5, 2025 16:20
@alicecaron alicecaron moved this from TODO to Waiting for review in Release 12/2025 Nov 6, 2025
@cphili cphili changed the title Add a check for minQ>maxQ (invert values) Check minQ>maxQ (reverted values) and put them in the order Nov 10, 2025
@cphili cphili changed the title Check minQ>maxQ (reverted values) and put them in the order Check minQ>maxQ (reverted values) and put them in right order Nov 10, 2025
@cphili cphili changed the title Check minQ>maxQ (reverted values) and put them in right order Add a check for reverted minQ>maxQ (if option enabled) Nov 10, 2025
@cphili cphili changed the title Add a check for reverted minQ>maxQ (if option enabled) Check reverted minQ>maxQ (if option enabled) Nov 10, 2025
@cphili cphili changed the title Check reverted minQ>maxQ (if option enabled) Add an option to check minQ>maxQ values Nov 10, 2025
@cphili cphili requested a review from geofjamg November 10, 2025 12:01
Signed-off-by: Clement Philipot <[email protected]>
@cphili cphili force-pushed the add_check_minq_maxq branch from e74efb6 to 3d4df5c Compare November 10, 2025 12:22
@cphili cphili changed the title Add an option to check minQ>maxQ values Add an option to check minQ < maxQ (reactive capability curves) Nov 10, 2025
@cphili cphili changed the title Add an option to check minQ < maxQ (reactive capability curves) Add an option to check minQ < maxQ (and reorder if reverted) Nov 10, 2025
@cphili cphili changed the title Add an option to check minQ < maxQ (and reorder if reverted) Add an option to check minQ < maxQ (reorder reverted values) Nov 10, 2025
@alicecaron alicecaron linked an issue Nov 12, 2025 that may be closed by this pull request
cphili and others added 6 commits November 12, 2025 14:53
…ctiveCapabilityCurveAdderImpl.java

Co-authored-by: CARON Alice <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
…erties

Co-authored-by: CARON Alice <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
@cphili cphili force-pushed the add_check_minq_maxq branch from 9d318ef to b96248a Compare November 12, 2025 14:38
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for review

Development

Successfully merging this pull request may close these issues.

Add an option to check minQ < maxQ (reorder reverted values)

4 participants