Fix export with custom voltage level topology #3659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Perrin <[email protected]>
8 tasks
olperr1
commented
Nov 19, 2025
| context.getWriter().writeStringAttribute("voltageLevelId" + index, context.getAnonymizer().anonymizeString(t.getVoltageLevel().getId())); | ||
| } | ||
| TopologyLevel topologyLevel = TopologyLevel.min(t.getVoltageLevel().getTopologyKind(), context.getOptions().getTopologyLevel()); | ||
| TopologyLevel topologyLevel = TopologyLevelUtil.determineTopologyLevel(t.getVoltageLevel(), context); |
Member
Author
There was a problem hiding this comment.
#3614 introduces a new writeNodeOrBus() method in ConnectableSerDeUtil.
This change should be reported in it too.
7 tasks
alicecaron
approved these changes
Nov 20, 2025
quinarygio
approved these changes
Nov 20, 2025
|
JacquesBorsenberger
pushed a commit
that referenced
this pull request
Nov 24, 2025
Fix export with custom voltage level topology (#3659) Signed-off-by: Olivier Perrin <[email protected]>
jeandemanged
added a commit
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Damien Jeandemange <[email protected]>
olperr1
pushed a commit
that referenced
this pull request
Nov 27, 2025
* dcNode, dcGround, dcLine, dcSwitch * fix equipment xsd * VSC reactive limits * AcDcConverter pccTerminal, DC terminals P & I * TerminalRefSerDe support for TerminalNumber * DcNode, DcGround, DcLine, DcSwitch serde test * LineCommutatedConverter, VoltageSourceConverter serde test * backward (in)compatibility tests * refactor read/write DcTerminal P&I * doc update * Allow setting AC/DC Converter PCC Terminal to be the converter first terminal * DcTerminal P&I SerDe: always dcP<num> and dcI<num> * Add control mode P_PCC_DROOP and DroopCurve Serde * future iidm versions > 1.15 will run backward compatibility tests * ConnectableSerDeUtil uses the new TopologyLevelUtil from #3659 * test export converter with VL TopologyLevel bus/branch Signed-off-by: Damien Jeandemange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
At IIDM export, when a specific topology level is specified for a voltage level, the generated file is invalid: the nodes or busses are correctly described, but the connectables may be incorrect (
nodeattributes instead ofbus/connectableBus).What is the new behavior (if this is a feature change)?
The generated files are valid.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
Fix problem with #3547