Skip to content

Fix environment var prefix consistency across commands and sub commands #33

@timdrysdale

Description

@timdrysdale

The options for session host aren't used in production yet (defaults are good), so I've just noticed that the env var prefix is different in the help message for the session host command, and in the internal library vw that implements it. Neither is consistent!

in cmd/session/host.go change help message to say SESSION_HOST_* instead of RELAYHOST_
in internal/vw change environment var prefix from vw to session_host (lower case by convention of envconfig command, which then looks for a capitalised env var as we want)

Notes:

The vw.Stream() function checks the environment variables, so in this present implementation it needs to know the command which is calling it. The reasons for doing it this way were (a) there is only one function calling this library so the alignment of the prefix is possible, and (b) this approach theoretically lets you pick up changes in the environment variables, although I don't think I'm using that capability at the minute (changing where you host the instance seems problematic ....)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions