wip

Author: privatenumber

README.md

@@ -255,7 +255,7 @@ _pkgroll_ automatically handles native Node.js addons (`.node` files) when you d
 
 ```js
 // src/index.js
-import nativeAddon from './native.node';
+import nativeAddon from './native.node'
 ```
 
 After bundling, the `.node` file will be copied to `dist/natives/` and the import will be automatically rewritten to load from the correct location at runtime.
@@ -264,6 +264,25 @@ After bundling, the `.node` file will be copied to `dist/natives/` and the impor
 > - Native modules are platform and architecture-specific. Make sure to distribute the correct `.node` files for your target platforms.
 > - This only works with direct `.node` imports. If you're using packages that dynamically load native modules via `bindings` or `node-pre-gyp`, you'll need to handle them separately.
 
+#### Handling dependencies with native modules
+
+If you're using packages with native modules (like `chokidar` which depends on `fsevents`):
+
+- **If in `dependencies`/`peerDependencies`**: ✅ Works automatically - these are externalized (not bundled)
+- **If in `devDependencies`**: ⚠️ Will be bundled. If they use `bindings()` or `node-pre-gyp` patterns, move them to `dependencies` instead, or use `optionalDependencies` if they're optional.
+
+Example - if you have `chokidar` in `devDependencies` and get build errors, move it to `dependencies`:
+
+```json
+{
+    "dependencies": {
+        "chokidar": "^3.0.0"
+    }
+}
+```
+
+This externalizes it (users will need to install it), avoiding the need to bundle its native modules.
+
 ### Environment variables
 Pass in compile-time environment variables with the `--env` flag.
 

src/rollup/plugins/native-modules.ts

@@ -13,13 +13,13 @@ const PREFIX = '\0natives:';
 export const nativeModules = (
 	distDirectory: string,
 ): Plugin => {
-	const nativeLibsDir = `${distDirectory}/natives`;
+	const nativeLibsDirectory = `${distDirectory}/natives`;
 	const copiedModules = new Map<string, string>();
 
 	return {
 		name: 'native-modules',
 
-		buildStart() {
+		buildStart: () => {
 			// Reset for watch mode
 			copiedModules.clear();
 		},
@@ -53,21 +53,21 @@ export const nativeModules = (
 
 			// Handle name collisions
 			while (Array.from(copiedModules.values()).includes(outputName)) {
-				const ext = path.extname(basename);
-				const name = path.basename(basename, ext);
-				outputName = `${name}_${counter}${ext}`;
-				counter++;
+				const extension = path.extname(basename);
+				const name = path.basename(basename, extension);
+				outputName = `${name}_${counter}${extension}`;
+				counter += 1;
 			}
 
-			const destPath = path.join(nativeLibsDir, outputName);
+			const destinationPath = path.join(nativeLibsDirectory, outputName);
 			const relativePath = `./natives/${outputName}`;
 
 			// Store mapping
 			copiedModules.set(resolvedPath, relativePath);
 
 			// Create directory and copy file
-			fs.mkdirSync(nativeLibsDir, { recursive: true });
-			fs.copyFileSync(resolvedPath, destPath);
+			fs.mkdirSync(nativeLibsDirectory, { recursive: true });
+			fs.copyFileSync(resolvedPath, destinationPath);
 
 			// Return prefixed ID for the load hook
 			return PREFIX + relativePath;

tests/specs/builds/native-modules.ts

@@ -78,8 +78,10 @@ export default testSuite(({ describe }, nodePath: string) => {
 			);
 
 			const pkgrollProcess = await pkgroll([
-				'--srcdist', 'src-a:dist-a',
-				'--srcdist', 'src-b:dist-b',
+				'--srcdist',
+				'src-a:dist-a',
+				'--srcdist',
+				'src-b:dist-b',
 			], {
 				cwd: fixture.path,
 				nodePath,