*/*: unify options for the copy command

In general we want to preserve everything and always follow symlinks.

Signed-off-by: Nowa Ammerlaan <[email protected]>

Author: Nowa-Ammerlaan

hooks/91-grub-mkconfig.install

@@ -38,7 +38,7 @@ main() {
 
 	if [[ -f ${GRUB_CFG} ]]; then
 		einfo "Backing up existing grub config as ${GRUB_CFG}~..."
-		cp -v "${GRUB_CFG}"{,~} || die "Failed to save existing config"
+		cp --dereference --preserve=all "${GRUB_CFG}"{,~} || die "Failed to save existing config"
 	fi
 
 	if [[ -f /etc/os-release ]]; then

hooks/95-refind-copy-icon.install

@@ -48,7 +48,7 @@ main() {
 	if [[ -f ${icon} ]]; then
 		mv "${icon}" "${icon_old}" || die
 	fi
-	cp "${REFIND_ICON}" "${icon}" || die "Failed to copy icon file"
+	cp --dereference --preserve=all "${REFIND_ICON}" "${icon}" || die "Failed to copy icon file"
 
 	# If there is a version-less image, install an icon for it
 	local icon_nover=${icon//-${ver}/}
@@ -67,11 +67,11 @@ main() {
 		ln -sf "$(basename "${icon}")" "${icon_nover}" || die
 	elif [[ -f ${icon_nover} ]]; then
 		mv "${icon_nover}" "${icon_nover_old}" || die
-		cp "${icon}" "${icon_nover}" || die
+		cp --dereference --preserve=all "${icon}" "${icon_nover}" || die
 	elif [[ -L ${img//-${ver}/} ]]; then
 		ln -sf "$(basename "${icon}")" "${icon_nover}" || die
 	elif [[ -f ${img//-${ver}/} ]]; then
-		cp "${icon}" "${icon_nover}" || die
+		cp --dereference --preserve=all "${icon}" "${icon_nover}" || die
 	fi
 }
 

hooks/systemd/90-zz-update-static.install

@@ -79,10 +79,10 @@ if [[ -L ${KERNEL_INSTALL_ROOT}/${STATIC_KERNEL_NAME}${SUFFIX} ]]; then
 	fi
 elif [[ -f ${KERNEL_INSTALL_ROOT}/${STATIC_KERNEL_NAME}${SUFFIX} ]]; then
 	[[ ${KERNEL_INSTALL_VERBOSE} == 1 ]] && echo "Updating static file for ${KERNEL_VERSION}..."
-	cp "${KERNEL_INSTALL_ROOT}/${STATIC_KERNEL_NAME}-${KERNEL_VERSION}${TRIES}${SUFFIX}" \
+	cp --dereference --preserve=all "${KERNEL_INSTALL_ROOT}/${STATIC_KERNEL_NAME}-${KERNEL_VERSION}${TRIES}${SUFFIX}" \
 		"${KERNEL_INSTALL_ROOT}/${STATIC_KERNEL_NAME}${SUFFIX}" || exit 1
 	if [[ -f ${KERNEL_INSTALL_ROOT}/initramfs-${KERNEL_VERSION}.img ]]; then
-		cp "${KERNEL_INSTALL_ROOT}/initramfs-${KERNEL_VERSION}.img" \
+		cp --dereference --preserve=all "${KERNEL_INSTALL_ROOT}/initramfs-${KERNEL_VERSION}.img" \
 			"${KERNEL_INSTALL_ROOT}/initramfs.img" || exit 1
 	fi
 fi

hooks/systemd/91-grub-mkconfig.install

@@ -73,7 +73,7 @@ if [[ ${COMMAND} == add || ${COMMAND} == remove ]]; then
 	if [[ -f ${GRUB_CFG} ]]; then
 		[[ ${KERNEL_INSTALL_VERBOSE} == 1 ]] && echo \
 			"Backing up existing grub config as ${GRUB_CFG}~"
-		cp "${GRUB_CFG}"{,~} || { echo "Failed to save existing config" && exit 1; }
+		cp --dereference --preserve=all "${GRUB_CFG}"{,~} || { echo "Failed to save existing config" && exit 1; }
 	fi
 
 	[[ ${KERNEL_INSTALL_VERBOSE} == 1 ]] && echo \

hooks/systemd/95-refind-copy-icon.install

@@ -40,12 +40,12 @@ if [[ ${KERNEL_INSTALL_LAYOUT} == "compat" || ${KERNEL_INSTALL_LAYOUT} == "grub"
 	KERNEL_INSTALL_BOOT_ROOT="/boot"
 	if [[ ${COMMAND} == add ]]; then
 		[[ ${KERNEL_INSTALL_VERBOSE} == 1 ]] && echo "Copying rEFInd icon file..."
-		cp "${REFIND_ICON}" "${KERNEL_INSTALL_BOOT_ROOT}/kernel-${KERNEL_VERSION}.png" || exit 1
+		cp --dereference --preserve=all "${REFIND_ICON}" "${KERNEL_INSTALL_BOOT_ROOT}/kernel-${KERNEL_VERSION}.png" || exit 1
 		if [[ -L ${KERNEL_INSTALL_BOOT_ROOT}/kernel ]]; then
 			ln -sf "kernel-${KERNEL_VERSION}.png" \
 				"${KERNEL_INSTALL_BOOT_ROOT}/kernel.png" || exit 1
 		elif [[ -f ${KERNEL_INSTALL_BOOT_ROOT}/kernel ]]; then
-			cp "${KERNEL_INSTALL_BOOT_ROOT}/kernel-${KERNEL_VERSION}.png" \
+			cp --dereference --preserve=all "${KERNEL_INSTALL_BOOT_ROOT}/kernel-${KERNEL_VERSION}.png" \
 				"${KERNEL_INSTALL_BOOT_ROOT}/kernel.png" || exit 1
 		fi
 	elif [[ ${COMMAND} == remove ]]; then
@@ -60,12 +60,12 @@ elif [[ ${KERNEL_INSTALL_LAYOUT} == "uki" ]]; then
 			exit 1
 		fi
 		[[ ${KERNEL_INSTALL_VERBOSE} == 1 ]] && echo "Copying rEFInd icon file..."
-		cp "${REFIND_ICON}" "${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}-${KERNEL_VERSION}.png" || exit 1
+		cp --dereference --preserve=all "${REFIND_ICON}" "${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}-${KERNEL_VERSION}.png" || exit 1
 		if [[ -L ${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}.efi ]]; then
 			ln -sf "${KERNEL_INSTALL_ENTRY_TOKEN}-${KERNEL_VERSION}.png" \
 				"${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}.png" || exit 1
 		elif [[ -f ${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}.efi ]]; then
-			cp "${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}-${KERNEL_VERSION}.png" \
+			cp --dereference --preserve=all "${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}-${KERNEL_VERSION}.png" \
 				"${UKI_DIR}/${KERNEL_INSTALL_ENTRY_TOKEN}.png" || exit 1
 		fi
 	elif [[ ${COMMAND} == remove ]]; then
@@ -76,12 +76,12 @@ elif [[ ${KERNEL_INSTALL_LAYOUT} == "efistub" ]]; then
 	EFISTUB_DIR="${KERNEL_INSTALL_BOOT_ROOT}/EFI/${NAME}"
 	if [[ ${COMMAND} == add ]]; then
 		[[ ${KERNEL_INSTALL_VERBOSE} == 1 ]] && echo "Copying rEFInd icon file..."
-		cp "${REFIND_ICON}" "${EFISTUB_DIR}/kernel-${KERNEL_VERSION}.png" || exit 1
+		cp --dereference --preserve=all "${REFIND_ICON}" "${EFISTUB_DIR}/kernel-${KERNEL_VERSION}.png" || exit 1
 		if [[ -L ${EFISTUB_DIR}/kernel.efi ]]; then
 			ln -sf "kernel-${KERNEL_VERSION}.png" \
 				"${EFISTUB_DIR}/kernel.png" || exit 1
 		elif [[ -f ${EFISTUB_DIR}/kernel.efi ]]; then
-			cp "${EFISTUB_DIR}/kernel-${KERNEL_VERSION}.png" \
+			cp --dereference --preserve=all "${EFISTUB_DIR}/kernel-${KERNEL_VERSION}.png" \
 				"${EFISTUB_DIR}/kernel.png" || exit 1
 		fi
 	elif [[ ${COMMAND} == remove ]]; then

installkernel

@@ -210,10 +210,10 @@ main() {
 					suffix=.efi
 					# backwards compatibility
 					if [ -f "/boot/intel-uc.img" ]; then
-						cp "/boot/intel-uc.img" "${dir}/intel-uc.img"
+						cp --dereference --preserve=all "/boot/intel-uc.img" "${dir}/intel-uc.img"
 					fi
 					if [ -f "/boot/amd-uc.img" ]; then
-						cp "/boot/amd-uc.img" "${dir}/amd-uc.img"
+						cp --dereference --preserve=all "/boot/amd-uc.img" "${dir}/amd-uc.img"
 					fi
 				else
 					continue